components/scheduler/renderer/renderer_task_duration.h - Issue 2184023002: Report the duration of sampled tasks with histogram.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/scheduler/renderer/renderer_task_duration.h

Issue 2184023002: Report the duration of sampled tasks with histogram. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/scheduler/renderer/renderer_scheduler_impl.h ('K') | « components/scheduler/renderer/renderer_scheduler_impl.cc ('k') | components/scheduler/renderer/renderer_task_duration.cc » ('j') | components/scheduler/renderer/renderer_task_duration.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONENTS_SCHEDULER_RENDERER_RENDERER_TASK_DURATION_H_

	6 #define COMPONENTS_SCHEDULER_RENDERER_RENDERER_TASK_DURATION_H_

	7

	8 #include "base/time/time.h"

	9

	10 namespace scheduler {

	11 class RendererTaskDuration {
	majidvp 2016/07/27 13:50:59 I think the convention is to have a blank line bef I think the convention is to have a blank line before class declaration but I couldn't find it in the style guide. So I am fine either way. majidvp 2016/07/27 13:50:59 I think a better name may be a TaskDurationReporte I think a better name may be a TaskDurationReporter. Also please add a class comment explaining what this class does and in particular the sampling interval. sunyunjia 2016/07/27 17:28:42 Done. Show quoted text On 2016/07/27 13:50:59, majidvp wrote: > I think a better name may be a TaskDurationReporter. > Also please add a class comment explaining what this class does and > in particular the sampling interval. Done. sunyunjia 2016/07/27 17:28:42 Done. Show quoted text On 2016/07/27 13:50:59, majidvp wrote: > I think the convention is to have a blank line before class declaration but I > couldn't find it in > the style guide. So I am fine either way. Done.
	12 public:

	13 RendererTaskDuration();

	14 ~RendererTaskDuration();

	15 void ReportSampleDuration(base::TimeDelta duration);

	16 static const int kSampleInterval = 100;
	majidvp 2016/07/27 13:50:59 This constant does not need to be public. Please m This constant does not need to be public. Please move to the implementation file. sunyunjia 2016/07/27 17:28:43 Done. Show quoted text On 2016/07/27 13:50:59, majidvp wrote: > This constant does not need to be public. Please move to the implementation > file. Done.
	17 private:

	18 int sample_count_;

	19 };
	majidvp 2016/07/27 13:50:59 This class is not meant to be copies/moved so plea This class is not meant to be copies/moved so please prevent these by using DISALLOW_COPY_AND_ASSIGN macro. sunyunjia 2016/07/27 17:28:42 Done. Show quoted text On 2016/07/27 13:50:59, majidvp wrote: > This class is not meant to be copies/moved so please prevent these by using > DISALLOW_COPY_AND_ASSIGN macro. Done.
	20 }

	21

	22 #endif // COMPONENTS_SCHEDULER_RENDERER_RENDERER_TASK_DURATION_H_

OLD	NEW