Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2184003002: Revert of Add virtual layout test for GPU accelerated decoding. (Closed)

Created:
4 years, 4 months ago by robliao
Modified:
4 years, 4 months ago
CC:
blink-reviews, chromium-reviews, feature-media-reviews_chromium.org, CalebRouleau
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add virtual layout test for GPU accelerated decoding. (patchset #8 id:140001 of https://codereview.chromium.org/1644763002/ ) Reason for revert: Suspected in breaking webkit tests: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/11324 unexpected_failures: virtual/media-gpu-accelerated/http/tests/media/media-source/mediasource-sourcebufferlist.html virtual/media-gpu-accelerated/http/tests/media/media-source/mediasource-appendstream-quota-exceeded.html virtual/media-gpu-accelerated/http/tests/media/media-source/mediasource-getvideoplaybackquality.html and more in mediasource-*.html Original issue's description: > Add gpu accelerated config changes to SmokeTests. > > SmokeTests are the subset of layout tests run on the android bots. This change > adds coverage to several historically problematic config-change scenarios. > > These tests use a virtual suite that sets the flag "--use-gpu-in-tests". This > flag overrides the default test behavior of using MesaGL, which is not capable > of creating surfaces to use with gpu accelerated decoding (at least on Android). > > This change also fixes some test/expectations rot. > > BUG=555703 > TESTS=Config change LayoutTests. > > Committed: https://crrev.com/b8bf5eba6b6cd3623f16404c746251bf662d141d > Cr-Commit-Position: refs/heads/master@{#407938} TBR=jochen@chromium.org,dpranke@chromium.org,wolenetz@chromium.org,chcunningham@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=555703 Committed: https://crrev.com/a7a23c40bb2e135ea185f171d201232b114afca0 Cr-Commit-Position: refs/heads/master@{#408010}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -83 lines) Patch
M content/browser/gpu/gpu_process_host.cc View 1 chunk +43 lines, -44 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/app/shell_main_delegate.cc View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/NeverFixTests View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/SmokeTests View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/VirtualTestSuites View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/android/http/tests/media/media-source/mediasource-config-change-mp4-a-bitrate-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/android/http/tests/media/media-source/mediasource-config-change-mp4-av-audio-bitrate-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/android/http/tests/media/media-source/mediasource-config-change-mp4-av-framesize-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/android/http/tests/media/media-source/mediasource-config-change-mp4-av-video-bitrate-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/android/http/tests/media/media-source/mediasource-config-change-mp4-v-bitrate-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/android/http/tests/media/media-source/mediasource-config-change-mp4-v-framerate-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/android/http/tests/media/media-source/mediasource-config-change-mp4-v-framesize-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/virtual/media-gpu-accelerated/http/tests/media/media-source/README.txt View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
robliao
Created Revert of Add virtual layout test for GPU accelerated decoding.
4 years, 4 months ago (2016-07-27 01:29:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2184003002/1
4 years, 4 months ago (2016-07-27 01:29:23 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 01:32:21 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a7a23c40bb2e135ea185f171d201232b114afca0 Cr-Commit-Position: refs/heads/master@{#408010}
4 years, 4 months ago (2016-07-27 01:35:19 UTC) #7
Dirk Pranke
4 years, 4 months ago (2016-07-27 01:57:39 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698