Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 2183993007: Add debug only counters to profiler (Closed)

Created:
4 years, 4 months ago by Cutch
Modified:
4 years, 4 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add debug only counters to profiler - [x] Count the reasons why we don't walk the stack. - [x] Count the reasons why we only sample a single frame. - [x] Count the stack walkers used. These counters are returned as part of the profile over the vm-service and can be used to debug profiler failures in the future. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/a6e2a7f0cd53c45fab21245f482b2b68a8d07e82

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -3 lines) Patch
M runtime/vm/profiler.h View 3 chunks +24 lines, -0 lines 0 comments Download
M runtime/vm/profiler.cc View 9 chunks +18 lines, -3 lines 0 comments Download
M runtime/vm/profiler_service.cc View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Cutch
4 years, 4 months ago (2016-07-28 01:08:53 UTC) #4
Florian Schneider
Lgtm. Thanks!
4 years, 4 months ago (2016-07-28 16:53:45 UTC) #5
Cutch
4 years, 4 months ago (2016-07-28 16:56:20 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a6e2a7f0cd53c45fab21245f482b2b68a8d07e82 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698