[WebAPK] Launch Play Store if the user does not have any web browsers installed

[WebAPK] Launch Play Store if the user does not have any web browsers installed

This CL:
- Tries to launch any web browser if launching the WebAPK fails
- Launches the Play Store to install the host browser if the user does not have any
  web browsers installed

BUG=628330
Committed: https://crrev.com/6dd8ec1011f388ec2fe710f4b4458fcf8d39903a
Cr-Commit-Position: refs/heads/master@{#413530}

[pkotwicz, 2016-07-27 01:21:29]

Patchset #1 (id:1) has been deleted

[pkotwicz, 2016-07-27 01:24:47]

pkotwicz@chromium.org changed reviewers:
+ yfriedman@chromium.org

[pkotwicz, 2016-07-27 01:24:48]

Yaron, can you please take a look?

I have implemented showing an alert and redirecting the user to the play store
if the user uninstalled the WebAPK's host browser.

A few concerns:
- We will need to translate the strings for the alert message. This is
inconvenient.
- I get a presubmit warning that I should be using
android.support.v7.app.AlertDialog instead of android.app.AlertDialog.

[Yaron, 2016-08-03 01:04:54]

On 2016/07/27 01:24:48, pkotwicz wrote:
> Yaron, can you please take a look?
> 
> I have implemented showing an alert and redirecting the user to the play store
> if the user uninstalled the WebAPK's host browser.
> 

I would ask someone from UI team to review. (tedchoc/twellington?)

> A few concerns:
> - We will need to translate the strings for the alert message. This is
> inconvenient.

Agreed. Presumably it can be translated as part of chrome translation process..
It's a shame though and probably requires a good amount of build-fu to get the
one string translated and into the webapk. I'm ok without this short-term (i.e.
dev preview).

> - I get a presubmit warning that I should be using
> android.support.v7.app.AlertDialog instead of android.app.AlertDialog.

Note the message:  "Avoid android.app.AlertDialog; if possible, use
android.support.v7.app.AlertDialog instead, which has a Material look on all
devices. (Some parts of the codebase can’t depend on the support library, in
which case android.app.AlertDialog is the only option"

I think that applies here so you can suppress it.

Change itself lgtm if one of above approves it

[Yaron, 2016-08-17 16:38:41]

On 2016/08/03 01:04:54, Yaron (limited availability) wrote:
> On 2016/07/27 01:24:48, pkotwicz wrote:
> > Yaron, can you please take a look?
> > 
> > I have implemented showing an alert and redirecting the user to the play
store
> > if the user uninstalled the WebAPK's host browser.
> > 
> 
> I would ask someone from UI team to review. (tedchoc/twellington?)
> 
> > A few concerns:
> > - We will need to translate the strings for the alert message. This is
> > inconvenient.
> 
> Agreed. Presumably it can be translated as part of chrome translation
process..
> It's a shame though and probably requires a good amount of build-fu to get the
> one string translated and into the webapk. I'm ok without this short-term
(i.e.
> dev preview).
> 
> > - I get a presubmit warning that I should be using
> > android.support.v7.app.AlertDialog instead of android.app.AlertDialog.
> 
> Note the message:  "Avoid android.app.AlertDialog; if possible, use
> android.support.v7.app.AlertDialog instead, which has a Material look on all
> devices. (Some parts of the codebase can’t depend on the support library, in
> which case android.app.AlertDialog is the only option"
> 
> I think that applies here so you can suppress it.
> 
> Change itself lgtm if one of above approves it

i think we can update this now per the discussion on the bug. see if someone can
resolve the intent for the start url, if they can't, redirect to play store for
host browser

[pkotwicz, 2016-08-18 22:19:18]

Patchset #2 (id:40001) has been deleted

[pkotwicz, 2016-08-18 22:21:08]

Description was changed from

==========
[WebAPK] Launch Play Store with host browser page if host browser was
uninstalled

BUG=628330
==========

to

==========
[WebAPK] Launch Play Store if the user does not have any web browsers installed

This CL:
- Tries to launch any web browser if launching the WebAPK fails
- Launches the Play Store to install the host browser if the user does not have
any
  web browsers installed

BUG=628330
==========

[pkotwicz, 2016-08-19 00:17:55]

Yaron can you please take another look? 

I have changed the CL to:
- launch any browser with the start URL if the WebAPK cannot be launched
- launch the Play Store to install the host browser if no web browser is
installed (No more dialog)

[Yaron, 2016-08-19 13:50:13]

lgtm

https://codereview.chromium.org/2183993002/diff/60001/chrome/android/webapk/s...
File
chrome/android/webapk/shell_apk/junit/src/org/chromium/webapk/shell_apk/MainActivityTest.java
(right):

https://codereview.chromium.org/2183993002/diff/60001/chrome/android/webapk/s...
chrome/android/webapk/shell_apk/junit/src/org/chromium/webapk/shell_apk/MainActivityTest.java:39:
private static final String META_RUNTIME_HOST =
"org.chromium.webapk.shell_apk.runtimeHost";
I think we should pull out constants somewhere central (common lib?) and rely on
those rather than redefining in the test.

https://codereview.chromium.org/2183993002/diff/60001/chrome/android/webapk/s...
File
chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java
(right):

https://codereview.chromium.org/2183993002/diff/60001/chrome/android/webapk/s...
chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java:152:
startActivity(createInstallIntent(hostBrowserPackageName));
technically this can also fail for devices without play.  We can give up at this
point but maybe not crash?

[pkotwicz, 2016-08-22 17:06:22]

Patchset #3 (id:80001) has been deleted

[pkotwicz, 2016-08-22 17:06:30]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2016-08-22 17:06:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
yfriedman@chromium.org
Link to the patchset: https://codereview.chromium.org/2183993002/#ps100001
(title: "Merge branch 'master' into webapk_chrome_not_installed")

[commit-bot: I haz the power, 2016-08-22 17:07:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 18:42:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 18:42:53]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[pkotwicz, 2016-08-22 18:52:06]

https://codereview.chromium.org/2183993002/diff/60001/chrome/android/webapk/s...
File
chrome/android/webapk/shell_apk/junit/src/org/chromium/webapk/shell_apk/MainActivityTest.java
(right):

https://codereview.chromium.org/2183993002/diff/60001/chrome/android/webapk/s...
chrome/android/webapk/shell_apk/junit/src/org/chromium/webapk/shell_apk/MainActivityTest.java:39:
private static final String META_RUNTIME_HOST =
"org.chromium.webapk.shell_apk.runtimeHost";
That's a good idea. I will do it in a separate CL

https://codereview.chromium.org/2183993002/diff/60001/chrome/android/webapk/s...
File
chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java
(right):

https://codereview.chromium.org/2183993002/diff/60001/chrome/android/webapk/s...
chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java:152:
startActivity(createInstallIntent(hostBrowserPackageName));
That's a good point. Thank you for pointing it out

[pkotwicz, 2016-08-22 18:52:14]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2016-08-22 18:53:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 21:01:02]

Description was changed from

==========
[WebAPK] Launch Play Store if the user does not have any web browsers installed

This CL:
- Tries to launch any web browser if launching the WebAPK fails
- Launches the Play Store to install the host browser if the user does not have
any
  web browsers installed

BUG=628330
==========

to

==========
[WebAPK] Launch Play Store if the user does not have any web browsers installed

This CL:
- Tries to launch any web browser if launching the WebAPK fails
- Launches the Play Store to install the host browser if the user does not have
any
  web browsers installed

BUG=628330
==========

[commit-bot: I haz the power, 2016-08-22 21:01:03]

Committed patchset #3 (id:100001)

[commit-bot: I haz the power, 2016-08-22 21:02:29]

Description was changed from

==========
[WebAPK] Launch Play Store if the user does not have any web browsers installed

This CL:
- Tries to launch any web browser if launching the WebAPK fails
- Launches the Play Store to install the host browser if the user does not have
any
  web browsers installed

BUG=628330
==========

to

==========
[WebAPK] Launch Play Store if the user does not have any web browsers installed

This CL:
- Tries to launch any web browser if launching the WebAPK fails
- Launches the Play Store to install the host browser if the user does not have
any
  web browsers installed

BUG=628330

Committed: https://crrev.com/6dd8ec1011f388ec2fe710f4b4458fcf8d39903a
Cr-Commit-Position: refs/heads/master@{#413530}
==========

[commit-bot: I haz the power, 2016-08-22 21:02:30]

Patchset 3 (id:??) landed as
https://crrev.com/6dd8ec1011f388ec2fe710f4b4458fcf8d39903a
Cr-Commit-Position: refs/heads/master@{#413530}