Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2183973002: Fix for an annoying ASSERT in blink when we tap on an editable portiion of the page

Created:
4 years, 4 months ago by ananta
Modified:
4 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for an annoying ASSERT in blink when we tap on an editable portiion of the page The reason for the ASSERT is blink is checking for the force field in the WebTouchEvent structure to be a valid value between 0 and 1. The touch event constructor we use in HWNDMessageHandler always ends up setting the force member in the PointerDetails structure to NaN. Fix is to use a different flavor of the TouchEvent constructor to set a force value of 0 BUG=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ui/views/win/hwnd_message_handler.cc View 1 chunk +2 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 3 (1 generated)
ananta
4 years, 4 months ago (2016-07-26 23:42:30 UTC) #2
sky
4 years, 4 months ago (2016-07-26 23:53:10 UTC) #3
NaN has a useful meaning for PointerDetails:

  // Force (pressure) of the touch. Normalized to be [0, 1] except NaN means
  // pressure is not supported by the input device.

I don't think we should change HWNDMessageHandler. If blink wants to ignore
no-force, it should be updated.

Powered by Google App Engine
This is Rietveld 408576698