Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2183963002: Revert of Mojo C++ bindings: make ipc/ mojom targets to use STL string/vector types (Closed)

Created:
4 years, 4 months ago by yzshen1
Modified:
4 years, 4 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Mojo C++ bindings: make ipc/ mojom targets to use STL string/vector types (patchset #2 id:20001 of https://codereview.chromium.org/2181443002/ ) Reason for revert: It seems this caused perf regression: https://bugs.chromium.org/p/chromium/issues/detail?id=631415 Original issue's description: > Mojo C++ bindings: make ipc/ mojom targets to use STL string/vector types > > BUG=624136 > > Committed: https://crrev.com/9d5c6a8af5e8298269dc0edf38831a8360be3c7b > Cr-Commit-Position: refs/heads/master@{#407340} TBR=rockot@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=624136 # No presubmit because the revert adds back use_new_wrapper_types = false for mojom targets which presubmit is not happy about. NOPRESUBMIT=true Committed: https://crrev.com/66ed8c82587c5329ce05ec33e36cd3beaffc8b48 Cr-Commit-Position: refs/heads/master@{#407982}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -51 lines) Patch
M ipc/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
M ipc/ipc.gyp View 2 chunks +4 lines, -0 lines 0 comments Download
M ipc/ipc_channel_mojo.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/ipc_channel_mojo.cc View 2 chunks +27 lines, -35 lines 0 comments Download
M ipc/ipc_channel_mojo_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/ipc_message_pipe_reader.h View 1 chunk +3 lines, -4 lines 0 comments Download
M ipc/ipc_message_pipe_reader.cc View 3 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
yzshen1
Created Revert of Mojo C++ bindings: make ipc/ mojom targets to use STL string/vector types
4 years, 4 months ago (2016-07-26 23:07:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2183963002/1
4 years, 4 months ago (2016-07-26 23:07:57 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/225678)
4 years, 4 months ago (2016-07-26 23:14:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2183963002/1
4 years, 4 months ago (2016-07-26 23:24:44 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 00:08:07 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 00:10:25 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/66ed8c82587c5329ce05ec33e36cd3beaffc8b48
Cr-Commit-Position: refs/heads/master@{#407982}

Powered by Google App Engine
This is Rietveld 408576698