Issue 218393010: DevTools: Fix PostOrder calculation algorithm in heap snapshot.

Issue 218393010: DevTools: Fix PostOrder calculation algorithm in heap snapshot. (Closed)

Created:
6 years, 8 months ago by alph

Modified:
6 years, 8 months ago

Reviewers:
eustas, yurys, loislo

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: Fix PostOrder calculation algorithm in heap snapshot. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170456

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressing comments #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -35 lines)			Patch
M	LayoutTests/inspector/profiler/heap-snapshot.html	View		2 chunks	+16 lines, -1 line	0 comments	Download
M	LayoutTests/inspector/profiler/heap-snapshot-expected.txt	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	LayoutTests/inspector/profiler/heap-snapshot-test.js	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/devtools/front_end/HeapSnapshot.js	View	1	2 chunks	+31 lines, -31 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

yurys

lgtm https://codereview.chromium.org/218393010/diff/1/LayoutTests/inspector/profiler/heap-snapshot-test.js File LayoutTests/inspector/profiler/heap-snapshot-test.js (right): https://codereview.chromium.org/218393010/diff/1/LayoutTests/inspector/profiler/heap-snapshot-test.js#newcode81 LayoutTests/inspector/profiler/heap-snapshot-test.js:81: 1, 1, 2, 2, 2, 0, 2, // ...

6 years, 8 months ago (2014-03-31 14:40:07 UTC) #2

alph

https://codereview.chromium.org/218393010/diff/1/LayoutTests/inspector/profiler/heap-snapshot-test.js File LayoutTests/inspector/profiler/heap-snapshot-test.js (right): https://codereview.chromium.org/218393010/diff/1/LayoutTests/inspector/profiler/heap-snapshot-test.js#newcode81 LayoutTests/inspector/profiler/heap-snapshot-test.js:81: 1, 1, 2, 2, 2, 0, 2, // A ...

6 years, 8 months ago (2014-03-31 14:52:01 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/218393010/20001

6 years, 8 months ago (2014-03-31 14:52:11 UTC) #5

Message was sent while issue was closed.

Change committed as 170456

Expand Messages | Collapse Messages