Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 218393003: Use OwnPtr|PassOwnPtr to pass a pointer of NavigatorContentUtilsClient instance (Closed)

Created:
6 years, 8 months ago by gyuyoung-inactive
Modified:
6 years, 8 months ago
CC:
blink-reviews, gyuyoung.kim_webkit.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Use OwnPtr|PassOwnPtr to pass a pointer of NavigatorContentUtilsClient instance WebViewImpl has owned m_navigatorContentUtilsClient member variable. However, it is only used for passing a pointer of NavigatorContentUtilsClient. It is useless. To remove it, we need to change parameter type to OwnPtr|PassOwnPtr in NavigatorContentUtils classes. Besides OwnPtr|PassOwnPtr help to manage the client pointer more safely. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170438

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M Source/modules/navigatorcontentutils/NavigatorContentUtils.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/navigatorcontentutils/NavigatorContentUtilsClient.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebViewImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
gyuyoung-inactive
Add haraken to reviewer.
6 years, 8 months ago (2014-03-30 10:28:23 UTC) #1
haraken
LGTM (but I'm not an OWNER of web/.)
6 years, 8 months ago (2014-03-30 11:43:15 UTC) #2
gyuyoung-inactive
The CQ bit was checked by gyuyoung.kim@samsung.com
6 years, 8 months ago (2014-03-30 11:46:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/218393003/1
6 years, 8 months ago (2014-03-30 11:46:16 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-30 11:56:57 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 8 months ago (2014-03-30 11:56:58 UTC) #6
gyuyoung-inactive
On 2014/03/30 11:43:15, haraken wrote: > LGTM (but I'm not an OWNER of web/.) Let ...
6 years, 8 months ago (2014-03-30 12:42:35 UTC) #7
gyuyoung-inactive
Add jochen to reviewer for WebViewImpl.h|cpp
6 years, 8 months ago (2014-03-30 12:43:54 UTC) #8
jochen (gone - plz use gerrit)
lgtm
6 years, 8 months ago (2014-03-31 09:59:59 UTC) #9
gyuyoung-inactive
The CQ bit was checked by gyuyoung.kim@samsung.com
6 years, 8 months ago (2014-03-31 10:07:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/218393003/1
6 years, 8 months ago (2014-03-31 10:07:32 UTC) #11
commit-bot: I haz the power
6 years, 8 months ago (2014-03-31 10:18:03 UTC) #12
Message was sent while issue was closed.
Change committed as 170438

Powered by Google App Engine
This is Rietveld 408576698