Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2183923005: Add Robolectric dependencies to setup_link directories. (Closed)

Created:
4 years, 4 months ago by mikecase (-- gone --)
Modified:
4 years, 4 months ago
Base URL:
https://chromium.googlesource.com/libyuv/libyuv.git@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Add Robolectric dependencies to setup_link directories. Currently, there are build issue that results from Robolectric not being able to find its dependencies. These errors for example look like... Unable to load: /b/build/slave/android_gn/build/src/third_party/bouncycastle/BUILD.gn I think updating the setup_links should resolve this issue.

Patch Set 1 #

Patch Set 2 : Updated .gitignore #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M .gitignore View 1 2 chunks +9 lines, -0 lines 0 comments Download
M setup_links.py View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
mikecase (-- gone --)
4 years, 4 months ago (2016-07-27 16:27:48 UTC) #2
mikecase (-- gone --)
This was the CL that introduced these new dependencies for Robolectric. https://codereview.chromium.org/2051913002/
4 years, 4 months ago (2016-07-27 16:28:26 UTC) #3
phoglund_chromium
lgtm
4 years, 4 months ago (2016-07-28 07:22:00 UTC) #4
phoglund_chromium
Maybe TBR this one to fbarchard if he's on vacation? Would be nice to get ...
4 years, 4 months ago (2016-07-28 07:24:11 UTC) #6
phoglund_chromium
Or wait actually, this is libyuv so it doesn't exactly block us.
4 years, 4 months ago (2016-07-28 07:24:28 UTC) #7
phoglund_chromium
We need a similar CL for WebRTC. Edward, can you do that?
4 years, 4 months ago (2016-07-28 07:29:50 UTC) #8
phoglund_chromium
Also, you need to update .gitignore to ignore the new dirs I believe.
4 years, 4 months ago (2016-07-28 12:09:19 UTC) #9
mikecase (-- gone --)
Updated the .gitignore
4 years, 4 months ago (2016-07-28 15:27:12 UTC) #10
mikecase (-- gone --)
On 2016/07/28 at 15:27:12, mikecase wrote: > Updated the .gitignore I tried to "git cl ...
4 years, 4 months ago (2016-07-28 15:32:54 UTC) #11
phoglund_chromium
4 years, 4 months ago (2016-07-28 15:34:45 UTC) #12
I'm not owner, so you need to tbr or get lgtm from fbarchard. Frank, you there?
:)

Powered by Google App Engine
This is Rietveld 408576698