Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2183923004: Reland [Tracing] V8 Tracing Controller (Closed)

Created:
4 years, 4 months ago by fmeawad
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland [Tracing] V8 Tracing Controller V8 has had a trace event macro interface for while, but without a tracing controller a standalone V8 would be unable to collect traces. This CL introduces a complete Tracing Controller system for V8. It is fully function except that it does not yet store trace event args. This CL has a few components, The tracing controller itself, contributed by the author of this CL The Trace config (including the parser), contributed by lpy@ The Trace Object, Trace Writer, and Trace Buffer are all contributed by rksang@ BUG=v8:4561 LOG=N The original CL was failing the V8 Arm Builder: https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm%20-%20builder/builds/2456 and the V8 Mips Builder: https://build.chromium.org/p/client.v8.ports/builders/V8%20Mips%20-%20builder/builds/2506 The failure is due to undefined behavior of CHECK_EQ of 2 const char* Fix in patch #1 Committed: https://crrev.com/3d598452679ce208ad9b2f48e0fb3fae352ce375 Cr-Commit-Position: refs/heads/master@{#38073} patch from issue 2137013006 at patchset 200001 (http://crrev.com/2137013006#ps200001) Committed: https://crrev.com/821c3e563ca33044e5cac2bc359f973944436b76 Cr-Commit-Position: refs/heads/master@{#38104}

Patch Set 1 #

Patch Set 2 : Fix CHECK_EQ undefined behavior in test-tracing to be determinstic #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1037 lines, -7 lines) Patch
M BUILD.gn View 1 chunk +8 lines, -0 lines 0 comments Download
M include/libplatform/libplatform.h View 2 chunks +9 lines, -0 lines 0 comments Download
A include/libplatform/v8-tracing.h View 1 chunk +232 lines, -0 lines 0 comments Download
M src/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M src/d8.h View 2 chunks +4 lines, -1 line 0 comments Download
M src/d8.cc View 4 chunks +28 lines, -0 lines 0 comments Download
M src/libplatform/default-platform.h View 4 chunks +7 lines, -1 line 0 comments Download
M src/libplatform/default-platform.cc View 4 chunks +32 lines, -5 lines 0 comments Download
A src/libplatform/tracing/trace-buffer.h View 1 chunk +48 lines, -0 lines 0 comments Download
A src/libplatform/tracing/trace-buffer.cc View 1 chunk +109 lines, -0 lines 0 comments Download
A src/libplatform/tracing/trace-config.cc View 1 chunk +36 lines, -0 lines 0 comments Download
A src/libplatform/tracing/trace-object.cc View 1 chunk +64 lines, -0 lines 0 comments Download
A src/libplatform/tracing/trace-writer.h View 1 chunk +30 lines, -0 lines 0 comments Download
A src/libplatform/tracing/trace-writer.cc View 1 chunk +57 lines, -0 lines 0 comments Download
A src/libplatform/tracing/tracing-controller.cc View 1 chunk +177 lines, -0 lines 0 comments Download
M src/v8.gyp View 1 chunk +8 lines, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A test/cctest/libplatform/test-tracing.cc View 1 1 chunk +186 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
fmeawad
PTAL.
4 years, 4 months ago (2016-07-27 15:53:45 UTC) #7
mattloring
On 2016/07/27 15:53:45, fmeawad wrote: > PTAL. lgtm
4 years, 4 months ago (2016-07-27 16:07:21 UTC) #8
jochen (gone - plz use gerrit)
lgtm
4 years, 4 months ago (2016-07-27 16:12:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2183923004/20001
4 years, 4 months ago (2016-07-27 16:19:32 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-27 16:21:25 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 16:22:05 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/821c3e563ca33044e5cac2bc359f973944436b76
Cr-Commit-Position: refs/heads/master@{#38104}

Powered by Google App Engine
This is Rietveld 408576698