Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: src/builtins/builtins-string.cc

Issue 2183923003: [stubs,interpreter] Optimise SMI loading for 64-bit targets. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Optimizing SMI loads at code stub assembler level. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/code-stub-assembler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins/builtins-string.cc
diff --git a/src/builtins/builtins-string.cc b/src/builtins/builtins-string.cc
index 7faf22da2f07e22ad9ca2677020d39150d8fa9f4..d38f6b069d50f5e751d7dfb3147f602a25b2d4f6 100644
--- a/src/builtins/builtins-string.cc
+++ b/src/builtins/builtins-string.cc
@@ -51,11 +51,8 @@ void Builtins::Generate_StringFromCharCode(CodeStubAssembler* assembler) {
assembler->Bind(&if_notoneargument);
{
// Determine the resulting string length.
- Node* parent_frame_length =
- assembler->Load(MachineType::Pointer(), parent_frame_pointer,
- assembler->IntPtrConstant(
- ArgumentsAdaptorFrameConstants::kLengthOffset));
- Node* length = assembler->SmiToWord(parent_frame_length);
+ Node* length = assembler->LoadAndUntagSmi(
+ parent_frame_pointer, ArgumentsAdaptorFrameConstants::kLengthOffset);
// Assume that the resulting string contains only one-byte characters.
Node* result = assembler->AllocateSeqOneByteString(context, length);
« no previous file with comments | « no previous file | src/code-stub-assembler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698