third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/disconnect-called-before.html - Issue 2183903002: bluetooth: Reject getPrimaryService(s) if frame is not connected

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/disconnect-called-before.html

Issue 2183903002: bluetooth: Reject getPrimaryService(s) if frame is not connected (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@my-origin

Patch Set: Clean up Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/device-disconnects-during.html ('K') | « third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/device-disconnects-during.html ('k') | third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/disconnect-called-during.html » ('j') | third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/disconnect-called-during.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../resources/testharness.js"></script>	2 <script src="../../resources/testharness.js"></script>

3 <script src="../../resources/testharnessreport.js"></script>	3 <script src="../../resources/testharnessreport.js"></script>

4 <script src="../../resources/bluetooth/bluetooth-helpers.js"></script>	4 <script src="../../resources/bluetooth/bluetooth-helpers.js"></script>

5 <script>	5 <script>

6 'use strict';	6 'use strict';

7 // TODO(ortuno): Write tests to check that "Disconnect" was actually

8 // called on the device.

9 // http://crbug.com/569716

10 promise_test(() => {	7 promise_test(() => {

11 return setBluetoothFakeAdapter('HeartRateAdapter')	8 return setBluetoothFakeAdapter('HeartRateAdapter')

12 .then(() => requestDeviceWithKeyDown({	9 .then(() => requestDeviceWithKeyDown({

13 filters: [{services: ['heart_rate']}]}))	10 filters: [{services: ['heart_rate']}]}))

14 .then(device => device.gatt.connect())	11 .then(device => device.gatt.connect())

15 .then(gattServer => {	12 .then(gattServer => {

16 gattServer.disconnect();	13 gattServer.disconnect();

17 assert_false(gattServer.connected);	14 return assert_promise_rejects_with_message(

	15 gattServer.getPrimaryService('heart_rate'),

	16 new DOMException('GATT Server is disconnected. Cannot retrieve services. ',

	17 'NetworkError'));

18 });	18 });

19 }, '\'connected\' is set to false after disconnect is called.');	19 }, 'disconnect() called before getPrimaryService. Reject with NetworkError.');

20 </script>	20 </script>

OLD	NEW