cc: Push valid property values when CalcDrawProps skips layer.

cc/layers/tiled_layer.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/layers/tiled_layer.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "base/auto_reset.h"
@@ skipping 716 matching lines @@
   previous_visible_rect_ = visible_content_rect();
 }
 
 bool TiledLayer::Update(ResourceUpdateQueue* queue,
                         const OcclusionTracker* occlusion) {
   DCHECK(!skips_draw_ && !failed_update_);  // Did ResetUpdateState get skipped?
   {
     base::AutoReset<bool> ignore_set_needs_commit(&ignore_set_needs_commit_,
                                                   true);
 
-    ContentsScalingLayer::Update(queue, occlusion);
+    bool contents_scaling_layer_updated =
+        ContentsScalingLayer::Update(queue, occlusion);
+    DCHECK(!contents_scaling_layer_updated) <<
+        "If this is true, then any return value below would need to " <<
+        "return true.";
     UpdateBounds();
   }
 
   if (tiler_->has_empty_bounds() || !DrawsContent())
     return false;
 
   bool did_paint = false;

[enne (OOO), 2013/08/02 22:04:55]

I think you could just initialize did_paint to contents_scaling_layer_updated
and you wouldn't need the DCHECK above?

[danakj, 2013/08/02 22:11:27]

Ah true, I think I'd like to rename this var to "updated" and just only have one
bool here, and match other layer types.

[enne (OOO), 2013/08/02 22:13:21]

sgtm!

 
   // Animation pre-paint. If the layer is small, try to paint it all
   // immediately whether or not it is occluded, to avoid paint/upload
   // hiccups while it is animating.
   if (IsSmallAnimatedLayer()) {
     int left, top, right, bottom;
     tiler_->ContentRectToTileIndices(gfx::Rect(content_bounds()),
                                      &left,
                                      &top,
                                      &right,
@@ skipping 136 matching lines @@
   gfx::Rect prepaint_rect = visible_content_rect();
   prepaint_rect.Inset(-tiler_->tile_size().width() * kPrepaintColumns,
                       -tiler_->tile_size().height() * kPrepaintRows);
   gfx::Rect content_rect(content_bounds());
   prepaint_rect.Intersect(content_rect);
 
   return prepaint_rect;
 }
 
 }  // namespace cc