Clean up on byte_stream (mainly style and includes)

content/browser/byte_stream.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_BYTE_STREAM_H_
 #define CONTENT_BROWSER_BYTE_STREAM_H_
 
-#include <deque>
-#include <set>
-#include <utility>
-
 #include "base/callback.h"
 #include "base/memory/ref_counted.h"
-#include "base/synchronization/lock.h"
+#include "base/memory/scoped_ptr.h"
 #include "content/common/content_export.h"
 #include "net/base/io_buffer.h"
 
 namespace base {
 class SequencedTaskRunner;
-}
+}  // namespace base

[Randy Smith (Not in Mondays), 2013/08/02 18:43:05]

Can you give me a pointer to the section of the style guide that specifies this
behavior?  I agree that it's common practice (including in the style guide
examples) to include a "// namespace" at the end of the namespace, but I can't
find it specified, and in that context, putting a closing comment two lines
after the namespace opening seems like unnecessary distracting text--it's
obvious to anyone looking at this code what the closing brace refers to.  (I
don't feel strongly, but I do have an opinion, so I'd like to at least have a
specific style guide directive to weigh against that opinion.)

[tyoshino (SeeGerritForStatus), 2013/08/05 07:53:11]

Yes, it's not explicitly stated but a common practice.
OK. It makes sense. Removed.

 
 namespace content {
 
 // A byte stream is a pipe to transfer bytes between a source and a
 // sink, which may be on different threads.  It is intended to be the
 // only connection between source and sink; they need have no
 // direct awareness of each other aside from the byte stream.  The source and
 // the sink have different interfaces to a byte stream, |ByteStreamWriter|
 // and |ByteStreamReader|.  A pair of connected interfaces is generated by
 // calling |CreateByteStream|.
@@ skipping 163 matching lines @@
 CONTENT_EXPORT void CreateByteStream(
     scoped_refptr<base::SequencedTaskRunner> input_task_runner,
     scoped_refptr<base::SequencedTaskRunner> output_task_runner,
     size_t buffer_size,
     scoped_ptr<ByteStreamWriter>* input,
     scoped_ptr<ByteStreamReader>* output);
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_BYTE_STREAM_H_