Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2183773003: DATALIST element: Filter DATALIST OPTIONs by sustring matching (Closed)

Created:
4 years, 4 months ago by tkent
Modified:
4 years, 4 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DATALIST element: Filter DATALIST OPTIONs by sustring matching Both of Firefox and Edge shows OPTIONs filtered by substring matching. We follow them. It seems that Firefox shows OPTIONs with matched labels, and Edge shows OPTIONs with matches values. We show OPTIONs with matched labels or values. BUG=153991 Committed: https://crrev.com/f8bb8bc5b0ecb2e7d63f598b52dfadf27cd3ed19 Cr-Commit-Position: refs/heads/master@{#407738}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -9 lines) Patch
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 1 chunk +12 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElementTest.cpp View 1 chunk +17 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
tkent
Keishi, would you review this please?
4 years, 4 months ago (2016-07-26 06:09:08 UTC) #4
keishi
LGTM
4 years, 4 months ago (2016-07-26 06:29:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2183773003/1
4 years, 4 months ago (2016-07-26 08:46:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 08:49:25 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 08:51:29 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f8bb8bc5b0ecb2e7d63f598b52dfadf27cd3ed19
Cr-Commit-Position: refs/heads/master@{#407738}

Powered by Google App Engine
This is Rietveld 408576698