Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 2183743002: Disable A Few More AppBannerDataFetcherBrowserTest Failing Tests (Closed)

Created:
4 years, 4 months ago by Mark P
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews, dominickn+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable A Few More AppBannerDataFetcherBrowserTest Failing Tests I didn't see these failures in the original lists I checked. TBR=dominickn@chromium.org BUG=631190 Committed: https://crrev.com/8945bfac334ff9b1ec226e158a1f29e3fdce5e0c Cr-Commit-Position: refs/heads/master@{#407707}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M chrome/browser/banners/app_banner_data_fetcher_browsertest.cc View 3 chunks +22 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2183743002/1
4 years, 4 months ago (2016-07-26 03:58:28 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 04:37:03 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8945bfac334ff9b1ec226e158a1f29e3fdce5e0c Cr-Commit-Position: refs/heads/master@{#407707}
4 years, 4 months ago (2016-07-26 04:38:23 UTC) #7
dominickn
4 years, 4 months ago (2016-07-26 09:15:40 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2182973002/ by dominickn@chromium.org.

The reason for reverting is: These test failures were caused by a bug in
https://codereview.chromium.org/2181553003/  Re-enabling. .

Powered by Google App Engine
This is Rietveld 408576698