Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2183723002: Mac (Cocoa) Omnibox: Force text field to LTR context if it is a URL. (Closed)

Created:
4 years, 4 months ago by Matt Giuca
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Mac (Cocoa) Omnibox: Force text field to LTR context if it is a URL. This means that URLs will be displayed in a left-to-right paragraph context. Right-to-left runs are still rendered RTL, but will not flip the whole URL around. For example (if "ABC" is Hebrew), this will render "ABC.com" as "CBA.com", rather than "com.CBA". Affects main text field and suggestions, but not non-URL search text. Complies with RFC 3987 Section 4.1 and brings the Mac Omnibox in line with the existing behaviour on Views and Android. BUG=624213 Review-Url: https://codereview.chromium.org/2126023003 Cr-Commit-Position: refs/heads/master@{#406791} (cherry picked from commit 05baf795316dd430afbd79ee915187bec6bf5f5d) Committed: https://chromium.googlesource.com/chromium/src/+/6ba00cae40b82241c6416e7d24c4d7aca7a227c6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm View 2 chunks +17 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Matt Giuca
4 years, 4 months ago (2016-07-26 03:28:48 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6ba00cae40b82241c6416e7d24c4d7aca7a227c6.

Powered by Google App Engine
This is Rietveld 408576698