content/public/app/mojo/content_renderer_manifest.json - Issue 2183703005: Renderers should obtain browser InterfaceProvider by connecting to browser

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/public/app/mojo/content_renderer_manifest.json

Issue 2183703005: Renderers should obtain browser InterfaceProvider by connecting to browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/common/mojo/mojo_shell_connection_impl.cc ('K') | « content/public/app/mojo/content_browser_manifest.json ('k') | content/public/browser/browser_context.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 {	1 {

2 "manifest_version": 1,	2 "manifest_version": 1,

3 "name": "exe:content_renderer",	3 "name": "exe:content_renderer",

4 "display_name": "Content Renderer",	4 "display_name": "Content Renderer",

5 "capabilities": {	5 "capabilities": {

6 "provided": {	6 "provided": {

7 "all_interfaces": [ "*" ]	7 "all_interfaces": [ "*" ]

8 },	8 },

9 "required": {	9 "required": {

	10 "exe:content_browser": {
	Ken Rockot(use gerrit already) 2016/07/29 17:09:46 nit: Maybe we should file a bug + add a TODO to na nit: Maybe we should file a bug + add a TODO to narrow the scope of the renderer's required interfaces, to make the intent clear?
	11 "classes": [ "all_interfaces" ]

	12 },

10 "mojo:ui": {	13 "mojo:ui": {

11 "interfaces": [	14 "interfaces": [

12 "ui::mojom::Gpu",	15 "ui::mojom::Gpu",

13 "ui::mojom::GpuService"	16 "ui::mojom::GpuService"

14 ]	17 ]

15 }	18 }

16 }	19 }

17 }	20 }

18 }	21 }

OLD	NEW