Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2183703004: Remove stray "extern" keyword for gs_EventActivity definition. (Closed)

Created:
4 years, 4 months ago by Tom Sepez
Modified:
4 years, 4 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove stray "extern" keyword for gs_EventActivity definition. BUG=pdfium:112 TBR=dsinclair@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/6c694f1b3e097da1be5381de83e9e0da85c5a6f8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M xfa/fxfa/app/xfa_ffdocview.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Tom Sepez
Dan, trivial review, TBR so I can close bug out and never think about this ...
4 years, 4 months ago (2016-07-26 22:57:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2183703004/1
4 years, 4 months ago (2016-07-26 22:57:40 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://pdfium.googlesource.com/pdfium/+/6c694f1b3e097da1be5381de83e9e0da85c5a6f8
4 years, 4 months ago (2016-07-26 23:10:45 UTC) #5
dsinclair
4 years, 4 months ago (2016-07-27 13:44:53 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698