Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2183703003: Added use of from_. (Closed)

Created:
4 years, 4 months ago by bakster
Modified:
4 years, 4 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M runtime/vm/object_reload.cc View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 7 (3 generated)
bakster
Fix
4 years, 4 months ago (2016-07-26 18:22:06 UTC) #2
Cutch
lgtm
4 years, 4 months ago (2016-07-26 18:22:29 UTC) #3
bakster
Committed patchset #1 (id:1) manually as a4a314251bf94a76957794ea82190f74c199cd26 (presubmit successful).
4 years, 4 months ago (2016-07-26 18:22:45 UTC) #5
Florian Schneider
4 years, 4 months ago (2016-07-26 19:57:24 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/2183703003/diff/1/runtime/vm/object_reload.cc
File runtime/vm/object_reload.cc (right):

https://codereview.chromium.org/2183703003/diff/1/runtime/vm/object_reload.cc...
runtime/vm/object_reload.cc:465: from_.ToCString();
Why not remove from_ completely?

Powered by Google App Engine
This is Rietveld 408576698