Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: tests_lit/asan_tests/instrumentload.ll

Issue 2183683003: Subzero: Removed unnecessary global access checks (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Small fixes Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceASanInstrumentation.cpp ('k') | tests_lit/asan_tests/instrumentstore.ll » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests_lit/asan_tests/instrumentload.ll
diff --git a/tests_lit/asan_tests/instrumentload.ll b/tests_lit/asan_tests/instrumentload.ll
index b0159053807fb97f5e961a41cdfbfc17c9632c07..fae7ea6138ca2ec902bda12da144afb649322089 100644
--- a/tests_lit/asan_tests/instrumentload.ll
+++ b/tests_lit/asan_tests/instrumentload.ll
@@ -5,20 +5,6 @@
; RUN: %p2i -i %s --args -verbose=inst -threads=0 -fsanitize-address \
; RUN: | FileCheck --check-prefix=DUMP %s
-; Constants to load data from
-@srcConst8 = internal constant [1 x i8] c"D"
-@srcConst16 = internal constant [2 x i8] c"DA"
-@srcConst32 = internal constant [4 x i8] c"DATA"
-@srcConst64 = internal constant [8 x i8] c"DATADATA"
-@srcConst128 = internal constant [16 x i8] c"DATADATADATADATA"
-
-; A global to load data from
-@srcGlobal8 = internal global [1 x i8] c"D"
-@srcGlobal16 = internal global [2 x i8] c"DA"
-@srcGlobal32 = internal global [4 x i8] c"DATA"
-@srcGlobal64 = internal global [8 x i8] c"DATADATA"
-@srcGlobal128 = internal global [16 x i8] c"DATADATADATADATA"
-
; A function with a local variable that does the loads
define internal void @doLoads(i32 %arg8, i32 %arg16, i32 %arg32, i32 %arg64,
i32 %arg128) {
@@ -28,30 +14,6 @@ define internal void @doLoads(i32 %arg8, i32 %arg16, i32 %arg32, i32 %arg64,
%srcLocal64 = inttoptr i32 %arg64 to i64*
%srcLocal128 = inttoptr i32 %arg128 to <4 x i32>*
- %ptrConst8 = bitcast [1 x i8]* @srcConst8 to i8*
- %ptrConst16 = bitcast [2 x i8]* @srcConst16 to i16*
- %ptrConst32 = bitcast [4 x i8]* @srcConst32 to i32*
- %ptrConst64 = bitcast [8 x i8]* @srcConst64 to i64*
- %ptrConst128 = bitcast [16 x i8]* @srcConst128 to <4 x i32>*
-
- %ptrGlobal8 = bitcast [1 x i8]* @srcGlobal8 to i8*
- %ptrGlobal16 = bitcast [2 x i8]* @srcGlobal16 to i16*
- %ptrGlobal32 = bitcast [4 x i8]* @srcGlobal32 to i32*
- %ptrGlobal64 = bitcast [8 x i8]* @srcGlobal64 to i64*
- %ptrGlobal128 = bitcast [16 x i8]* @srcGlobal128 to <4 x i32>*
-
- %dest1 = load i8, i8* %ptrConst8, align 1
- %dest2 = load i16, i16* %ptrConst16, align 1
- %dest3 = load i32, i32* %ptrConst32, align 1
- %dest4 = load i64, i64* %ptrConst64, align 1
- %dest5 = load <4 x i32>, <4 x i32>* %ptrConst128, align 4
-
- %dest6 = load i8, i8* %ptrGlobal8, align 1
- %dest7 = load i16, i16* %ptrGlobal16, align 1
- %dest8 = load i32, i32* %ptrGlobal32, align 1
- %dest9 = load i64, i64* %ptrGlobal64, align 1
- %dest10 = load <4 x i32>, <4 x i32>* %ptrGlobal128, align 4
-
%dest11 = load i8, i8* %srcLocal8, align 1
%dest12 = load i16, i16* %srcLocal16, align 1
%dest13 = load i32, i32* %srcLocal32, align 1
@@ -64,26 +26,6 @@ define internal void @doLoads(i32 %arg8, i32 %arg16, i32 %arg32, i32 %arg64,
; DUMP-LABEL: ================ Instrumented CFG ================
; DUMP-NEXT: define internal void @doLoads(
; DUMP-NEXT: __0:
-; DUMP-NEXT: call void @__asan_check_load(i32 @srcConst8, i32 1)
-; DUMP-NEXT: %dest1 = load i8, i8* @srcConst8, align 1
-; DUMP-NEXT: call void @__asan_check_load(i32 @srcConst16, i32 2)
-; DUMP-NEXT: %dest2 = load i16, i16* @srcConst16, align 1
-; DUMP-NEXT: call void @__asan_check_load(i32 @srcConst32, i32 4)
-; DUMP-NEXT: %dest3 = load i32, i32* @srcConst32, align 1
-; DUMP-NEXT: call void @__asan_check_load(i32 @srcConst64, i32 8)
-; DUMP-NEXT: %dest4 = load i64, i64* @srcConst64, align 1
-; DUMP-NEXT: call void @__asan_check_load(i32 @srcConst128, i32 16)
-; DUMP-NEXT: %dest5 = load <4 x i32>, <4 x i32>* @srcConst128, align 4
-; DUMP-NEXT: call void @__asan_check_load(i32 @srcGlobal8, i32 1)
-; DUMP-NEXT: %dest6 = load i8, i8* @srcGlobal8, align 1
-; DUMP-NEXT: call void @__asan_check_load(i32 @srcGlobal16, i32 2)
-; DUMP-NEXT: %dest7 = load i16, i16* @srcGlobal16, align 1
-; DUMP-NEXT: call void @__asan_check_load(i32 @srcGlobal32, i32 4)
-; DUMP-NEXT: %dest8 = load i32, i32* @srcGlobal32, align 1
-; DUMP-NEXT: call void @__asan_check_load(i32 @srcGlobal64, i32 8)
-; DUMP-NEXT: %dest9 = load i64, i64* @srcGlobal64, align 1
-; DUMP-NEXT: call void @__asan_check_load(i32 @srcGlobal128, i32 16)
-; DUMP-NEXT: %dest10 = load <4 x i32>, <4 x i32>* @srcGlobal128, align 4
; DUMP-NEXT: call void @__asan_check_load(i32 %arg8, i32 1)
; DUMP-NEXT: %dest11 = load i8, i8* %arg8, align 1
; DUMP-NEXT: call void @__asan_check_load(i32 %arg16, i32 2)
« no previous file with comments | « src/IceASanInstrumentation.cpp ('k') | tests_lit/asan_tests/instrumentstore.ll » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698