Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2183633002: Roll libyuv chromium deps to same as webrtc jun8 (Closed)

Created:
4 years, 4 months ago by fbarchard1
Modified:
4 years, 4 months ago
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Merge branch 'master' of https://chromium.googlesource.com/libyuv/libyuv into jun8 #

Patch Set 4 : re-add DEPS to roll. #

Total comments: 2

Patch Set 5 : revert DEPS roll, keep other changes from Jun 8 roll. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M .gn View 1 chunk +1 line, -0 lines 0 comments Download
M libyuv.gyp View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
fbarchard1
4 years, 4 months ago (2016-07-26 00:43:05 UTC) #1
kjellander_chromium
I suggest rolling to a newer revision instead. There seems to be something missing with ...
4 years, 4 months ago (2016-08-01 20:21:42 UTC) #2
fbarchard1
On 2016/08/01 20:21:42, kjellander_chromium wrote: > I suggest rolling to a newer revision instead. There ...
4 years, 4 months ago (2016-08-02 19:35:28 UTC) #3
kjellander_chromium
On 2016/08/02 19:35:28, fbarchard1 wrote: > On 2016/08/01 20:21:42, kjellander_chromium wrote: > > I suggest ...
4 years, 4 months ago (2016-08-02 20:53:40 UTC) #4
fbarchard1
https://codereview.chromium.org/2183633002/diff/60001/libyuv.gyp File libyuv.gyp (right): https://codereview.chromium.org/2183633002/diff/60001/libyuv.gyp#newcode37 libyuv.gyp:37: 'linux_use_bundled_gold%': 0, On 2016/08/01 20:21:42, kjellander_chromium wrote: > You ...
4 years, 4 months ago (2016-08-02 21:26:19 UTC) #5
fbarchard1
4 years, 4 months ago (2016-08-02 21:42:37 UTC) #7
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
e75fcb03e5dc06a517f819ee4732d4d7727bf8ab (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698