third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp - Issue 2183623004: Add IDLDictionaryBase

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp

Issue 2183623004: Add IDLDictionaryBase (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comment Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.h ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInit.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp

index 5abbbd99d0e42e65fce912488b4575d7ca6364bf..ac27b33bdd4d72acb55cb82f72682f6dc0aa3be1 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp

@@ -91,18 +91,19 @@ void V8TestDictionaryDerivedImplementedAs::toImpl(v8::Isolate* isolate, v8::Loca

}

-v8::Local<v8::Value> toV8(const TestDictionaryDerivedImplementedAs& impl, v8::Local<v8::Object> creationContext, v8::Isolate* isolate)

+v8::Local<v8::Value> TestDictionaryDerivedImplementedAs::toV8Impl(v8::Local<v8::Object> creationContext, v8::Isolate* isolate) const

{

v8::Local<v8::Object> v8Object = v8::Object::New(isolate);

- if (!toV8TestDictionary(impl, v8Object, creationContext, isolate))

- return v8::Local<v8::Value>();

- if (!toV8TestDictionaryDerivedImplementedAs(impl, v8Object, creationContext, isolate))

+ if (!toV8TestDictionaryDerivedImplementedAs(*this, v8Object, creationContext, isolate))

return v8::Local<v8::Value>();

return v8Object;

}

bool toV8TestDictionaryDerivedImplementedAs(const TestDictionaryDerivedImplementedAs& impl, v8::Local<v8::Object> dictionary, v8::Local<v8::Object> creationContext, v8::Isolate* isolate)

{

+ if (!toV8TestDictionary(impl, dictionary, creationContext, isolate))

+ return false;

if (impl.hasDerivedStringMember()) {

if (!v8CallBoolean(dictionary->CreateDataProperty(isolate->GetCurrentContext(), v8String(isolate, "derivedStringMember"), v8String(isolate, impl.derivedStringMember()))))

return false;