third_party/WebKit/Source/bindings/scripts/v8_dictionary.py - Issue 2183623004: Add IDLDictionaryBase

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_dictionary.py

Issue 2183623004: Add IDLDictionaryBase (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix multi-level inheritance bug Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/scripts/v8_dictionary.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_dictionary.py b/third_party/WebKit/Source/bindings/scripts/v8_dictionary.py

index 3db6a3b0a0f8c3a40736ba09c6b3a771de293e46..e2ff61bccbfaabdd148855e804d071fc6dd3a75b 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_dictionary.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_dictionary.py

@@ -173,6 +173,10 @@ def dictionary_impl_context(dictionary, interfaces_info):

if parent_interface_info:

context['header_includes'].add(

parent_interface_info['include_path'])

+ else:

+ context['parent_cpp_class'] = 'IDLDictionaryBase'

+ context['header_includes'].add(

+ 'bindings/core/v8/IDLDictionaryBase.h')

return context