Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2183613003: (gyp): breakpad_host should push include_dirs to dependents (Closed)

Created:
4 years, 5 months ago by Mostyn Bramley-Moore
Modified:
4 years, 4 months ago
Reviewers:
Lei Zhang, wzhong
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

(gyp): breakpad_host should push include_dirs to dependents Followup to https://codereview.chromium.org/2169063002 BUG=internal b/30003601 TBR=thestig@chromium.org Committed: https://crrev.com/e1a1f4026ef11d25da6558aae5e78a0423b7d768 Cr-Commit-Position: refs/heads/master@{#407758}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M components/crash.gypi View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Mostyn Bramley-Moore
@wzhong, Lei Zhang: please take a look at this followup to https://codereview.chromium.org/2169063002
4 years, 5 months ago (2016-07-26 09:08:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2183613003/1
4 years, 5 months ago (2016-07-26 10:21:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 10:24:50 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e1a1f4026ef11d25da6558aae5e78a0423b7d768 Cr-Commit-Position: refs/heads/master@{#407758}
4 years, 4 months ago (2016-07-26 10:26:23 UTC) #13
Lei Zhang
4 years, 4 months ago (2016-07-26 17:31:07 UTC) #14
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698