Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2183573002: Remove unused code and ipc_handle_win.(h|cc). (Closed)

Created:
4 years, 5 months ago by nasko
Modified:
4 years, 5 months ago
Reviewers:
jam, Will Harris
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused code and ipc_handle_win.(h|cc). BUG= Committed: https://crrev.com/c82eb96ca4985cf045777db617263dbbe53c5a5f Cr-Commit-Position: refs/heads/master@{#407645}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -41 lines) Patch
M ipc/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ipc/ipc.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D ipc/ipc_handle_win.h View 1 chunk +0 lines, -22 lines 0 comments Download
D ipc/ipc_handle_win.cc View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
nasko
Hey Will, Can you review this CL for me? It removes some unused code. Thanks ...
4 years, 5 months ago (2016-07-25 22:28:18 UTC) #4
Will Harris
if bots like it then lgtm
4 years, 5 months ago (2016-07-25 22:33:00 UTC) #5
nasko
Hey John, Can you do an OWNERS review? Thanks in advance! Nasko
4 years, 5 months ago (2016-07-25 22:33:50 UTC) #7
jam
lgtm
4 years, 5 months ago (2016-07-26 00:07:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2183573002/1
4 years, 5 months ago (2016-07-26 00:08:28 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-26 00:13:34 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-26 00:15:26 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c82eb96ca4985cf045777db617263dbbe53c5a5f
Cr-Commit-Position: refs/heads/master@{#407645}

Powered by Google App Engine
This is Rietveld 408576698