Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2183543003: DevTools: Keep timeline counters graph colors independent of dark theme. (Closed)

Created:
4 years, 5 months ago by alph
Modified:
4 years, 4 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Keep timeline counters graph colors independent of dark theme. BUG=630841 Committed: https://crrev.com/84d81e7261b6a6e823e362eedf501157200013bf Cr-Commit-Position: refs/heads/master@{#408335}

Patch Set 1 #

Patch Set 2 : redid it #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/timeline/CountersGraph.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css View 1 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
alph
4 years, 5 months ago (2016-07-25 21:49:26 UTC) #2
alph
ptal
4 years, 5 months ago (2016-07-25 22:38:29 UTC) #3
pfeldman
lgtm
4 years, 4 months ago (2016-07-28 00:05:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2183543003/20001
4 years, 4 months ago (2016-07-28 00:11:32 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-28 04:17:49 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 04:19:52 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/84d81e7261b6a6e823e362eedf501157200013bf
Cr-Commit-Position: refs/heads/master@{#408335}

Powered by Google App Engine
This is Rietveld 408576698