Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2183513002: PathBuilderKeyRolloverTest.TestMultipleRootMatchesOnlyOneWorks shouldn't depend on trust store orde… (Closed)

Created:
4 years, 4 months ago by mattm
Modified:
4 years, 4 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PathBuilderKeyRolloverTest.TestMultipleRootMatchesOnlyOneWorks shouldn't depend on trust store ordering. BUG=631139 Committed: https://crrev.com/6608820ad7702f86ed322ba59487a59570356d35 Cr-Commit-Position: refs/heads/master@{#407629}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -16 lines) Patch
M net/cert/internal/path_builder_unittest.cc View 1 2 chunks +21 lines, -16 lines 1 comment Download

Messages

Total messages: 12 (7 generated)
mattm
4 years, 4 months ago (2016-07-25 22:08:59 UTC) #4
eroman
lgtm https://codereview.chromium.org/2183513002/diff/20001/net/cert/internal/path_builder_unittest.cc File net/cert/internal/path_builder_unittest.cc (right): https://codereview.chromium.org/2183513002/diff/20001/net/cert/internal/path_builder_unittest.cc#newcode608 net/cert/internal/path_builder_unittest.cc:608: // mock version of TrustStore that returns roots ...
4 years, 4 months ago (2016-07-25 22:13:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2183513002/20001
4 years, 4 months ago (2016-07-25 23:25:04 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-25 23:29:38 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-25 23:31:15 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6608820ad7702f86ed322ba59487a59570356d35
Cr-Commit-Position: refs/heads/master@{#407629}

Powered by Google App Engine
This is Rietveld 408576698