Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1033)

Unified Diff: include/effects/SkBlurMaskFilter.h

Issue 21835004: Blur refactoring (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Removed unneeded #includes Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/effects/SkBlurDrawLooper.h ('k') | include/effects/SkEmbossMaskFilter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/effects/SkBlurMaskFilter.h
===================================================================
--- include/effects/SkBlurMaskFilter.h (revision 10932)
+++ include/effects/SkBlurMaskFilter.h (working copy)
@@ -33,27 +33,39 @@
kAll_BlurFlag = 0x03
};
+ /**
+ * DEPRECATED - radius-based
+ */
+ static SkMaskFilter* Create(SkScalar radius, BlurStyle style,
+ uint32_t flags = kNone_BlurFlag);
+
/** Create a blur maskfilter.
- @param radius The radius to extend the blur from the original mask. Must be > 0.
@param style The BlurStyle to use
+ @param sigma Standard deviation of the Gaussian blur to apply. Must be > 0.
@param flags Flags to use - defaults to none
@return The new blur maskfilter
*/
- static SkMaskFilter* Create(SkScalar radius, BlurStyle style,
+ static SkMaskFilter* Create(BlurStyle style, SkScalar sigma,
uint32_t flags = kNone_BlurFlag);
/** Create an emboss maskfilter
+ @param blurSigma standard deviation of the Gaussian blur to apply
+ before applying lighting (e.g. 3)
@param direction array of 3 scalars [x, y, z] specifying the direction of the light source
@param ambient 0...1 amount of ambient light
@param specular coefficient for specular highlights (e.g. 8)
- @param blurRadius amount to blur before applying lighting (e.g. 3)
@return the emboss maskfilter
*/
- static SkMaskFilter* CreateEmboss( const SkScalar direction[3],
- SkScalar ambient, SkScalar specular,
- SkScalar blurRadius);
+ static SkMaskFilter* CreateEmboss(SkScalar blurSigma, const SkScalar direction[3],
+ SkScalar ambient, SkScalar specular);
+ // DEPRECATED - radius-based
+ static SkMaskFilter* CreateEmboss(const SkScalar direction[3],
+ SkScalar ambient, SkScalar specular,
+ SkScalar blurRadius);
+
SK_DECLARE_FLATTENABLE_REGISTRAR_GROUP()
+
private:
SkBlurMaskFilter(); // can't be instantiated
};
« no previous file with comments | « include/effects/SkBlurDrawLooper.h ('k') | include/effects/SkEmbossMaskFilter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698