Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2183483003: lock special-raster while the caller's bitmap is in-scope (Closed)

Created:
4 years, 4 months ago by reed1
Modified:
4 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

lock special-raster while the caller's bitmap is in-scope previous CL that removed the specialimage subclass that wrapped the original image: https://codereview.chromium.org/2164073004 BUG=skia:5574 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2183483003 Committed: https://skia.googlesource.com/skia/+/bd2bd5c56d244d1e4270e2aca7a5bdac0d1517d0

Patch Set 1 #

Patch Set 2 : undo flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M src/core/SkSpecialImage.cpp View 2 chunks +13 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
reed1
4 years, 4 months ago (2016-07-25 20:44:12 UTC) #6
mtklein
lgtm
4 years, 4 months ago (2016-07-25 20:46:53 UTC) #7
reed1
Will land this, as I think it makes the world safer. But will revisit that ...
4 years, 4 months ago (2016-07-25 21:24:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2183483003/20001
4 years, 4 months ago (2016-07-25 21:25:08 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-07-25 21:26:05 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/bd2bd5c56d244d1e4270e2aca7a5bdac0d1517d0

Powered by Google App Engine
This is Rietveld 408576698