Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 2183483002: Clean up ash::ShellTestApi (Closed)

Created:
4 years, 5 months ago by James Cook
Modified:
4 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up ash::ShellTestApi Don't use the test API to access things that can be directly accessed from WmShell. BUG=none TEST=ash_unittests Committed: https://crrev.com/956f85452786effa48d8ed5f025a0e148661cc8e Cr-Commit-Position: refs/heads/master@{#407563}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -37 lines) Patch
M ash/shelf/shelf_view_unittest.cc View 2 chunks +1 line, -3 lines 0 comments Download
M ash/shelf/shelf_window_watcher_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/test/shell_test_api.h View 2 chunks +0 lines, -8 lines 0 comments Download
M ash/test/shell_test_api.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M ash/wm/dock/docked_window_resizer_unittest.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M ash/wm/panels/panel_layout_manager_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ash/wm/panels/panel_window_resizer_unittest.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
James Cook
sky, please take a look.
4 years, 5 months ago (2016-07-25 18:32:50 UTC) #3
sky
LGTM
4 years, 5 months ago (2016-07-25 20:14:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2183483002/1
4 years, 5 months ago (2016-07-25 20:20:52 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 20:25:17 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 20:28:03 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/956f85452786effa48d8ed5f025a0e148661cc8e
Cr-Commit-Position: refs/heads/master@{#407563}

Powered by Google App Engine
This is Rietveld 408576698