Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2183473005: Clean up some unused atomic routines. (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
bungeman-skia, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Clean up some unused atomic routines. AtomicTest was the only use of sk_atomic_add(). AtomicInc64 bench was the only use of sk_atomic_inc(int64_t*). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2183473005 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-TSAN-Trybot,Test-Ubuntu-GCC-Golo-GPU-GT610-x86_64-Release-TSAN-Trybot Committed: https://skia.googlesource.com/skia/+/570c868b38c7bd56bb1bc3b73d94cdd7069a04bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -94 lines) Patch
M bench/RefCntBench.cpp View 2 chunks +0 lines, -25 lines 0 comments Download
M include/private/SkAtomics.h View 1 chunk +2 lines, -5 lines 0 comments Download
D tests/AtomicTest.cpp View 1 chunk +0 lines, -64 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
mtklein_C
4 years, 4 months ago (2016-07-27 11:38:26 UTC) #5
bungeman-skia
lgtm
4 years, 4 months ago (2016-07-27 14:41:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2183473005/1
4 years, 4 months ago (2016-07-27 15:39:46 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 15:40:48 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/570c868b38c7bd56bb1bc3b73d94cdd7069a04bd

Powered by Google App Engine
This is Rietveld 408576698