Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2183453003: Google3 <functional> has a global "using std::plus"... (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Google3 <functional> has a global "using std::plus"... ... so we can't use the name plus(). -_- TBR=tomhudson@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2183453003 Committed: https://skia.googlesource.com/skia/+/1ab9e59da057e02ece707d736032c756fb3ce9cf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/core/SkXfermode.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2183453003/1
4 years, 4 months ago (2016-07-25 20:06:15 UTC) #4
mtklein_C
4 years, 4 months ago (2016-07-25 20:06:18 UTC) #6
tomhudson
LGTM, sigh.
4 years, 4 months ago (2016-07-25 20:08:02 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-07-25 20:24:13 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1ab9e59da057e02ece707d736032c756fb3ce9cf

Powered by Google App Engine
This is Rietveld 408576698