Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2183433003: Revert of HttpChunkedDecoder: Support chunks longer than 2^31-1 bytes. (Closed)

Created:
4 years, 4 months ago by Mark P
Modified:
4 years, 4 months ago
Reviewers:
eroman, mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of HttpChunkedDecoder: Support chunks longer than 2^31-1 bytes. (patchset #4 id:60001 of https://codereview.chromium.org/2170133004/ ) Reason for revert: Speculative revert for bug 631246. Have no better ideas. Apologies if this wasn't the cause. Original issue's description: > HttpChunkedDecoder: Support chunks longer than 2^31-1 bytes. > > We were using HexStringToInt to parse chunk size, which returns a > 32-bit int. This CL switches to using HexStringToInt64, which uses > 64-bit ints, so we can now support chunks up to 2^63-1 bytes. > > That should be enough for anybody. [Cue dramatic music] > > BUG=630680 > > Committed: https://crrev.com/8ea249f8b70f154f9995ed538fc853fe9cf46503 > Cr-Commit-Position: refs/heads/master@{#407549} TBR=eroman@chromium.org,mmenke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=630680 Committed: https://crrev.com/2321e8a45603ca595296b67e4d064c070f2b3591 Cr-Commit-Position: refs/heads/master@{#407651}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -90 lines) Patch
M net/http/http_chunked_decoder.h View 2 chunks +2 lines, -3 lines 0 comments Download
M net/http/http_chunked_decoder.cc View 6 chunks +14 lines, -19 lines 0 comments Download
M net/http/http_chunked_decoder_unittest.cc View 2 chunks +4 lines, -68 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Mark P
Created Revert of HttpChunkedDecoder: Support chunks longer than 2^31-1 bytes.
4 years, 4 months ago (2016-07-26 00:31:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2183433003/1
4 years, 4 months ago (2016-07-26 00:32:36 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 00:33:44 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2321e8a45603ca595296b67e4d064c070f2b3591 Cr-Commit-Position: refs/heads/master@{#407651}
4 years, 4 months ago (2016-07-26 00:35:00 UTC) #7
mmenke
4 years, 4 months ago (2016-07-26 04:00:51 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2180063002/ by mmenke@chromium.org.

The reason for reverting is: The CL was blamed for compile failures it didn't
cause, re-landing..

Powered by Google App Engine
This is Rietveld 408576698