third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp - Issue 2183423002: Only do security checks on javascript: URLs for frames for loading

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp

Issue 2183423002: Only do security checks on javascript: URLs for frames for loading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp b/third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp

index a68f5d7774d4e23cd38ff2668fc0550fc47c248b..87753c332dc4f19f9f334b5614627b4153a67fae 100644

--- a/third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp

@@ -126,7 +126,7 @@ void HTMLIFrameElement::parseAttribute(const QualifiedName& name, const AtomicSt

bool HTMLIFrameElement::layoutObjectIsNeeded(const ComputedStyle& style)

{

- return isURLAllowed() && HTMLElement::layoutObjectIsNeeded(style);

+ return isURLAllowed(WillNotLoadURL) && HTMLElement::layoutObjectIsNeeded(style);

}

LayoutObject* HTMLIFrameElement::createLayoutObject(const ComputedStyle&)

« third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp ('K') | « third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp ('k') | no next file » | no next file with comments »