Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2183383004: Revert of [heap] Reland "Remove black pages and use black areas instead." (Closed)

Created:
4 years, 4 months ago by Hannes Payer (out of office)
Modified:
4 years, 4 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Reland "Remove black pages and use black areas instead." (patchset #4 id:60001 of https://codereview.chromium.org/2185613002/ ) Reason for revert: Still crashing. Original issue's description: > [heap] Reland "Remove black pages and use black areas instead." > > BUG=chromium:630969, chromium:630386 > LOG=n > > Committed: https://crrev.com/9e37a07c8de0a20ef2681e26824ff4d329102603 > Cr-Commit-Position: refs/heads/master@{#38057} TBR=ulan@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:630969, chromium:630386 Committed: https://crrev.com/2c7efba658e6f48e115c7ff17d1d1053e5825e06 Cr-Commit-Position: refs/heads/master@{#38129}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -355 lines) Patch
M src/heap/heap.cc View 4 chunks +9 lines, -25 lines 0 comments Download
M src/heap/heap-inl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/heap/incremental-marking.h View 1 chunk +4 lines, -9 lines 0 comments Download
M src/heap/incremental-marking.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M src/heap/mark-compact.h View 2 chunks +3 lines, -13 lines 0 comments Download
M src/heap/mark-compact.cc View 11 chunks +72 lines, -27 lines 0 comments Download
M src/heap/mark-compact-inl.h View 1 chunk +8 lines, -26 lines 0 comments Download
M src/heap/marking.h View 2 chunks +19 lines, -92 lines 0 comments Download
M src/heap/scavenger.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/spaces.h View 3 chunks +14 lines, -5 lines 0 comments Download
M src/heap/spaces.cc View 7 chunks +22 lines, -58 lines 0 comments Download
M src/heap/spaces-inl.h View 3 chunks +2 lines, -6 lines 0 comments Download
M src/ia32/assembler-ia32-inl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/objects-inl.h View 1 chunk +4 lines, -3 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M test/unittests/heap/marking-unittest.cc View 1 chunk +0 lines, -46 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Hannes Payer (out of office)
Created Revert of [heap] Reland "Remove black pages and use black areas instead."
4 years, 4 months ago (2016-07-28 10:03:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2183383004/1
4 years, 4 months ago (2016-07-28 10:03:34 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 10:29:16 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 10:29:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c7efba658e6f48e115c7ff17d1d1053e5825e06
Cr-Commit-Position: refs/heads/master@{#38129}

Powered by Google App Engine
This is Rietveld 408576698