|
|
DescriptionEnable RenderPassDrawQuad promotion to CALayer.
This CL enables the Core Animation compositor's implementation of CSS filter
effects.
BUG=581526
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
Committed: https://crrev.com/c2e44129f9712162be14a1a054225e29d89b1296
Cr-Commit-Position: refs/heads/master@{#408216}
Patch Set 1 #
Messages
Total messages: 26 (15 generated)
Description was changed from ========== Enable RenderPassDrawQuad promotion to CALayer. This CL enables the Core Animation compositor's implementation of CSS filter effects. BUG=581526 ========== to ========== Enable RenderPassDrawQuad promotion to CALayer. This CL enables the Core Animation compositor's implementation of CSS filter effects. BUG=581526 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel ==========
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
erikchen@chromium.org changed reviewers: + ccameron@chromium.org
ccameron: Please review.
lgtm ... exciting!!!!!
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Your CL was about to rely on recently removed CQ feature(s): * master.tryserver.blink builder linux_blink_rel was renamed to linux_precise_blink_rel (http://crbug.com/590036)
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Your CL was about to rely on recently removed CQ feature(s): * master.tryserver.blink builder linux_blink_rel was renamed to linux_precise_blink_rel (http://crbug.com/590036)
Description was changed from ========== Enable RenderPassDrawQuad promotion to CALayer. This CL enables the Core Animation compositor's implementation of CSS filter effects. BUG=581526 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel ========== to ========== Enable RenderPassDrawQuad promotion to CALayer. This CL enables the Core Animation compositor's implementation of CSS filter effects. BUG=581526 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ==========
tandrii@google.com changed reviewers: + tandrii@google.com
i've renamed your description to fix the bot name.
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Enable RenderPassDrawQuad promotion to CALayer. This CL enables the Core Animation compositor's implementation of CSS filter effects. BUG=581526 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ========== to ========== Enable RenderPassDrawQuad promotion to CALayer. This CL enables the Core Animation compositor's implementation of CSS filter effects. BUG=581526 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Enable RenderPassDrawQuad promotion to CALayer. This CL enables the Core Animation compositor's implementation of CSS filter effects. BUG=581526 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ========== to ========== Enable RenderPassDrawQuad promotion to CALayer. This CL enables the Core Animation compositor's implementation of CSS filter effects. BUG=581526 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/c2e44129f9712162be14a1a054225e29d89b1296 Cr-Commit-Position: refs/heads/master@{#408216} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/c2e44129f9712162be14a1a054225e29d89b1296 Cr-Commit-Position: refs/heads/master@{#408216}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2193623004/ by erikchen@chromium.org. The reason for reverting is: Has correctness problems: https://bugs.chromium.org/p/chromium/issues/detail?id=632613#c5 And likely performance problems: https://bugs.chromium.org/p/chromium/issues/detail?id=632636. |