Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1318)

Issue 2183333002: Enable RenderPassDrawQuad promotion to CALayer. (Closed)

Created:
4 years, 4 months ago by erikchen
Modified:
4 years, 4 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable RenderPassDrawQuad promotion to CALayer. This CL enables the Core Animation compositor's implementation of CSS filter effects. BUG=581526 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/c2e44129f9712162be14a1a054225e29d89b1296 Cr-Commit-Position: refs/heads/master@{#408216}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -15 lines) Patch
M cc/output/ca_layer_overlay.h View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/output/ca_layer_overlay.cc View 3 chunks +1 line, -11 lines 0 comments Download
M cc/output/overlay_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 26 (15 generated)
erikchen
ccameron: Please review.
4 years, 4 months ago (2016-07-27 17:36:24 UTC) #7
ccameron
lgtm ... exciting!!!!!
4 years, 4 months ago (2016-07-27 18:49:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2183333002/1
4 years, 4 months ago (2016-07-27 18:59:31 UTC) #10
commit-bot: I haz the power
Your CL was about to rely on recently removed CQ feature(s): * master.tryserver.blink builder linux_blink_rel ...
4 years, 4 months ago (2016-07-27 19:01:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2183333002/1
4 years, 4 months ago (2016-07-27 19:08:35 UTC) #14
commit-bot: I haz the power
Your CL was about to rely on recently removed CQ feature(s): * master.tryserver.blink builder linux_blink_rel ...
4 years, 4 months ago (2016-07-27 19:08:37 UTC) #16
tandrii_google
i've renamed your description to fix the bot name.
4 years, 4 months ago (2016-07-27 19:10:26 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2183333002/1
4 years, 4 months ago (2016-07-27 19:11:39 UTC) #21
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 19:44:49 UTC) #23
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c2e44129f9712162be14a1a054225e29d89b1296 Cr-Commit-Position: refs/heads/master@{#408216}
4 years, 4 months ago (2016-07-27 19:46:47 UTC) #25
erikchen
4 years, 4 months ago (2016-07-29 17:30:45 UTC) #26
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2193623004/ by erikchen@chromium.org.

The reason for reverting is: Has correctness problems:
https://bugs.chromium.org/p/chromium/issues/detail?id=632613#c5

And likely performance problems:
https://bugs.chromium.org/p/chromium/issues/detail?id=632636.

Powered by Google App Engine
This is Rietveld 408576698