Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2183323004: Fix ParseConfigs_ViaParsing test when skia_angle=1 (Closed)

Created:
4 years, 4 months ago by Brian Osman
Modified:
4 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix ParseConfigs_ViaParsing test when skia_angle=1 The handling of angle-gl changes with SK_ANGLE. We don't have any bots that test this particular combination, but I see it all the time while running DM for other things. Previously considered changing things so that the config parsing results are consistent, regardless of GYP_DEFINES, but this is much simpler (and more consistent with the other code we already have for testing config parsing). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2183323004 Committed: https://skia.googlesource.com/skia/+/577e025ca6bc5258fe6f2d64ca4c380bee7b5f08

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M tests/TestConfigParsing.cpp View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Brian Osman
4 years, 4 months ago (2016-07-27 15:26:22 UTC) #5
bsalomon
lgtm
4 years, 4 months ago (2016-07-27 15:29:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2183323004/1
4 years, 4 months ago (2016-07-27 15:30:38 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 16:21:55 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/577e025ca6bc5258fe6f2d64ca4c380bee7b5f08

Powered by Google App Engine
This is Rietveld 408576698