Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2183313007: [gn] Add missing deps to inspector_protocol_parser_test (Closed)

Created:
4 years, 4 months ago by Michael Achenbach
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Add missing deps to inspector_protocol_parser_test This is required for all executables. BUG=chromium:580337 TBR=yangguo@chromium.org, jochen@chromium.org, pfeldman@chromium.org NOTRY=true Committed: https://crrev.com/37b20704d2c75aeaf76e43b7dc18d271ac1fc1c9 Cr-Commit-Position: refs/heads/master@{#38117}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M test/inspector_protocol_parser_test/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Achenbach
TBR
4 years, 4 months ago (2016-07-28 08:19:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2183313007/1
4 years, 4 months ago (2016-07-28 08:20:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 08:21:25 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/37b20704d2c75aeaf76e43b7dc18d271ac1fc1c9 Cr-Commit-Position: refs/heads/master@{#38117}
4 years, 4 months ago (2016-07-28 08:23:28 UTC) #10
Yang
4 years, 4 months ago (2016-07-28 10:45:29 UTC) #11
Message was sent while issue was closed.
On 2016/07/28 08:23:28, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/37b20704d2c75aeaf76e43b7dc18d271ac1fc1c9
> Cr-Commit-Position: refs/heads/master@{#38117}

lgtm.

Powered by Google App Engine
This is Rietveld 408576698