[chrome_elf] Big ELF cleanup. Part 1.

chrome_elf/crash/crash_helper.h

Index: chrome_elf/crash/crash_helper.h
diff --git a/chrome_elf/crash/crash_helper.h b/chrome_elf/crash/crash_helper.h
new file mode 100644
index 0000000000000000000000000000000000000000..26753bd740018a5b67b3d800ab0a5ca396c820b6
--- /dev/null
+++ b/chrome_elf/crash/crash_helper.h
@@ -0,0 +1,29 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_ELF_CRASH_CRASH_HELPER_H_
+#define CHROME_ELF_CRASH_CRASH_HELPER_H_
+
+#include <windows.h>
+
+// Keep all crash-related APIs here.  All other chrome_elf code should call here
+// for crash support.
+namespace elf_crash {
+
+// Init the crash handling system for entire process.
+void InitializeCrashReportingForProcess();

[robertshield, 2016/08/02 02:38:41]

Is the ForProcess suffix needed?

[penny, 2016/08/02 21:07:43]

Done.

+
+// Any late cleanup before DLL unload.
+void DllDetachCrashReportingCleanup();

[robertshield, 2016/08/02 02:38:40]

This is a complementary function to InitializeCrashReportingForProcess(). They
should be named similarly:

InitializeCrashReportingForProcess()
ShutdownCrashReportingForProcess()

or

DllAttachCrashReportingSetup()
DllDetachCrashReportingCleanup()

.. 

I like the versions that don't implicitly encode the expected callsite in the
name best.

[penny, 2016/08/02 21:07:43]

Done.

+
+// Used to control unhandled-exception filters.

[robertshield, 2016/08/02 02:38:41]

This is a crazy and awesome hack and should be documented a bit more. How about
something like 

"Permanently neuters subsequent calls to kernel32!SetUnhandledExceptionFilter(),
see comments in .cc for why this is needed."

[penny, 2016/08/02 21:07:43]

Done.

+void DisableSetUnhandledExceptionFilter();
+
+// Exception handler for exceptions in chrome_elf which need to be passed on to
+// the next handler in the chain. Examples include exceptions in DllMain,
+// blacklist interception code, etc.

[robertshield, 2016/08/02 02:38:40]

This comment should also mention that the handler takes a minidump.

[penny, 2016/08/02 21:07:43]

Done.

+int GenerateCrashDump(EXCEPTION_POINTERS* exception_pointers);
+}
+
+#endif  // CHROME_ELF_CRASH_CRASH_HELPER_H_