Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1865)

Unified Diff: chrome_elf/elf_imports_unittest.cc

Issue 2183263003: [chrome_elf] Big ELF cleanup. Part 1. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update with latest trunk. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome_elf/crash/crash_helper.cc ('k') | chrome_elf/hook_util/hook_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_elf/elf_imports_unittest.cc
diff --git a/chrome_elf/elf_imports_unittest.cc b/chrome_elf/elf_imports_unittest.cc
index e466c9b4ac36aa5835ddf63404e38b10b182d6e3..96e078c96caa02ab11a14efe1440e4577a36d280 100644
--- a/chrome_elf/elf_imports_unittest.cc
+++ b/chrome_elf/elf_imports_unittest.cc
@@ -144,7 +144,9 @@ TEST_F(ELFImportsTest, DISABLED_ChromeElfLoadSanityTestImpl) {
// We don't expect user32 to be loaded in chrome_elf_unittests. If this test
// case fails, then it means that a dependency on user32 has crept into the
// chrome_elf_unittests executable, which needs to be removed.
- EXPECT_EQ(nullptr, ::GetModuleHandle(L"user32.dll"));
+ // NOTE: it may be a secondary dependency of another system DLL. If so,
+ // try adding a "/DELAYLOAD:<blah>.dll" to the build.gn file.
+ ASSERT_EQ(nullptr, ::GetModuleHandle(L"user32.dll"));
HMODULE chrome_elf_module_handle = ::LoadLibrary(dll.value().c_str());
EXPECT_TRUE(chrome_elf_module_handle != nullptr);
« no previous file with comments | « chrome_elf/crash/crash_helper.cc ('k') | chrome_elf/hook_util/hook_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698