Make WinsockInitSingleton explicitly leaky to avoid the AssertSingletonAllowed() dcheck.

net/base/winsock_init.cc

Index: net/base/winsock_init.cc
diff --git a/net/base/winsock_init.cc b/net/base/winsock_init.cc
index e7601859e78ac4ccaceee63cccbb16ec155c0b93..1f488c96c6bf2459e99aa5f008a69fa3985c9c5e 100644
--- a/net/base/winsock_init.cc
+++ b/net/base/winsock_init.cc
@@ -30,15 +30,12 @@ class WinsockInitSingleton {
       WSAGetLastError();
     }
   }
-
-  ~WinsockInitSingleton() {

[gab, 2016/07/27 14:29:17]

On the bug when I said "delete the destructor" I meant to do so explicitly
(C++11 style) so that the compiler verifies the destructor is never invoked,
i.e. something like:

// The singleton instance has to be leaked (ref. comment on 
// |g_winsock_init_singleton| below).
~WinsockInitSingleton() = delete;

[gab, 2016/08/09 16:46:32]

ping, I think this would be cleaner, can you do this?

-    // Don't call WSACleanup() since the worker pool threads can continue to
-    // call getaddrinfo() after Winsock has shutdown, which can lead to crashes.
-  }
 };
 
-static base::LazyInstance<WinsockInitSingleton> g_winsock_init_singleton =
-    LAZY_INSTANCE_INITIALIZER;
+// Worker pool threads that use the Windows Sockets API may still be running at
+// shutdown. Leak instance and skip cleanup.
+static base::LazyInstance<WinsockInitSingleton>::Leaky
+    g_winsock_init_singleton = LAZY_INSTANCE_INITIALIZER;
 
 }  // namespace