Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2183203002: Check for null card/profile before recording usage stats (Closed)

Created:
4 years, 4 months ago by please use gerrit instead
Modified:
4 years, 4 months ago
Reviewers:
Mathieu
CC:
chromium-reviews, rouslan+autofill_chromium.org, estade+watch_chromium.org, vabr+watchlistautofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check for null card/profile before recording usage stats BUG=631540 Committed: https://crrev.com/8bb1c166237c95778473d046a1bd3fd4d9876c03 Cr-Commit-Position: refs/heads/master@{#407899}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/autofill/android/personal_data_manager_android.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
please use gerrit instead
Mathieu, ptal. This fix is speculative.
4 years, 4 months ago (2016-07-26 19:33:46 UTC) #4
please use gerrit instead
Mathieu, ptal. This fix is speculative.
4 years, 4 months ago (2016-07-26 19:33:47 UTC) #5
Mathieu
sure, lgtm
4 years, 4 months ago (2016-07-26 19:50:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2183203002/1
4 years, 4 months ago (2016-07-26 20:16:48 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 20:28:50 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 20:29:56 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8bb1c166237c95778473d046a1bd3fd4d9876c03
Cr-Commit-Position: refs/heads/master@{#407899}

Powered by Google App Engine
This is Rietveld 408576698