mus: Change PointerWatcher to observe all pointer events, with moves optional.

services/ui/public/cpp/tests/window_tree_client_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "services/ui/public/cpp/window_tree_client.h"
 
 #include <stdint.h>
 
 #include "base/logging.h"
 #include "base/macros.h"
@@ skipping 77 matching lines @@
 
   TestWindowTreeClientDelegate* window_tree_delegate() {
     return &window_tree_delegate_;
   }
 
   Window* GetFirstRoot() {
     return client()->GetRoots().empty() ? nullptr
                                         : *client()->GetRoots().begin();
   }
 
-  uint32_t GetEventObserverId() {
-    return WindowTreeClientPrivate(&tree_client_).event_observer_id();
+  uint32_t GetPointerWatcherId() {
+    return WindowTreeClientPrivate(&tree_client_).pointer_watcher_id();
   }
 
  private:
   TestWindowTree window_tree_;
   TestWindowTreeClientDelegate window_tree_delegate_;
   WindowTreeClient tree_client_;
 
   DISALLOW_COPY_AND_ASSIGN(WindowTreeSetup);
 };
 
@@ skipping 356 matching lines @@
   EXPECT_TRUE(setup.window_tree()->WasEventAcked(33));
 }
 
 // Tests event observers triggered by events that did not hit a target in this
 // window tree.
 TEST_F(WindowTreeClientTest, OnEventObserved) {
   WindowTreeSetup setup;
   Window* root = setup.GetFirstRoot();
   ASSERT_TRUE(root);
 
-  // Set up an event observer.
-  mojom::EventMatcherPtr matcher = mojom::EventMatcher::New();
-  matcher->type_matcher = mojom::EventTypeMatcher::New();
-  matcher->type_matcher->type = ui::mojom::EventType::POINTER_DOWN;
-  setup.client()->SetEventObserver(std::move(matcher));
+  // Start a pointer watcher for all events excluding move events.
+  setup.client()->StartPointerWatcher(false /* want_moves */);
 
   // Simulate the server sending an observed event.
-  uint32_t event_observer_id = setup.GetEventObserverId();
+  uint32_t pointer_watcher_id = setup.GetPointerWatcherId();
   std::unique_ptr<ui::Event> ui_event(
       new ui::MouseEvent(ui::ET_MOUSE_PRESSED, gfx::Point(), gfx::Point(),

[James Cook, 2016/07/27 01:54:01]

Change all these test events to PointerEvents, since that's what the pointer
watcher actually uses.

[riajiang, 2016/07/27 22:39:16]

Done.

                          ui::EventTimeForNow(), ui::EF_CONTROL_DOWN, 0));
   setup.window_tree_client()->OnEventObserved(ui::Event::Clone(*ui_event.get()),
-                                              event_observer_id);
+                                              pointer_watcher_id);
 
   // Delegate sensed the event.
   ui::Event* last_event = setup.window_tree_delegate()->last_event_observed();
   EXPECT_EQ(ui::ET_MOUSE_PRESSED, last_event->type());
   EXPECT_EQ(ui::EF_CONTROL_DOWN, last_event->flags());
   setup.window_tree_delegate()->Reset();
 
-  // Clear the event observer.
-  setup.client()->SetEventObserver(nullptr);
+  // Stop the pointer watcher.
+  setup.client()->StopPointerWatcher();
 
   // Simulate another event from the server.
   setup.window_tree_client()->OnEventObserved(ui::Event::Clone(*ui_event.get()),
-                                              event_observer_id);
+                                              pointer_watcher_id);
 
   // No event was sensed.
   EXPECT_FALSE(setup.window_tree_delegate()->last_event_observed());
 }
 
 // Tests event observers triggered by events that hit this window tree.
 TEST_F(WindowTreeClientTest, OnWindowInputEventWithEventObserver) {
   WindowTreeSetup setup;
   Window* root = setup.GetFirstRoot();
   ASSERT_TRUE(root);
 
-  // Set up an event observer.
-  mojom::EventMatcherPtr matcher = mojom::EventMatcher::New();
-  matcher->type_matcher = mojom::EventTypeMatcher::New();
-  matcher->type_matcher->type = ui::mojom::EventType::POINTER_DOWN;
-  setup.client()->SetEventObserver(std::move(matcher));
+  // Start a pointer watcher for all events excluding move events.
+  setup.client()->StartPointerWatcher(false /* want_moves */);
 
   // Simulate the server dispatching an event that also matched the observer.
-  uint32_t event_observer_id = setup.GetEventObserverId();
+  uint32_t pointer_watcher_id = setup.GetPointerWatcherId();
   std::unique_ptr<ui::Event> ui_event(
       new ui::MouseEvent(ui::ET_MOUSE_PRESSED, gfx::Point(), gfx::Point(),
                          ui::EventTimeForNow(), ui::EF_CONTROL_DOWN, 0));
   setup.window_tree_client()->OnWindowInputEvent(
-      1, server_id(root), std::move(ui_event), event_observer_id);
+      1, server_id(root), std::move(ui_event), pointer_watcher_id);
 
   // Delegate sensed the event.
   ui::Event* last_event = setup.window_tree_delegate()->last_event_observed();
   EXPECT_EQ(ui::ET_MOUSE_PRESSED, last_event->type());
   EXPECT_EQ(ui::EF_CONTROL_DOWN, last_event->flags());
 }
 
-// Tests that replacing an event observer with a new one results in only new
-// events being observed.
+// Tests that replacing a pointer watcher with a new one that has different
+// |want_moves| values results in only new events being observed.
 TEST_F(WindowTreeClientTest, EventObserverReplaced) {
   WindowTreeSetup setup;
   Window* root = setup.GetFirstRoot();
   ASSERT_TRUE(root);
 
-  // Set up an event observer.
-  mojom::EventMatcherPtr matcher1 = mojom::EventMatcher::New();
-  matcher1->type_matcher = mojom::EventTypeMatcher::New();
-  matcher1->type_matcher->type = ui::mojom::EventType::POINTER_DOWN;
-  setup.client()->SetEventObserver(std::move(matcher1));
-  uint32_t event_observer_id1 = setup.GetEventObserverId();
+  // Start a pointer watcher for all events excluding move events.
+  setup.client()->StartPointerWatcher(false /* want_moves */);
+  uint32_t pointer_watcher_id1 = setup.GetPointerWatcherId();
 
-  // Replace it with a second observer.
-  mojom::EventMatcherPtr matcher2 = mojom::EventMatcher::New();
-  matcher2->type_matcher = mojom::EventTypeMatcher::New();
-  matcher2->type_matcher->type = ui::mojom::EventType::POINTER_UP;
-  setup.client()->SetEventObserver(std::move(matcher2));
-  uint32_t event_observer_id2 = setup.GetEventObserverId();
+  // Replace it with a second watcher that also watches for move events.
+  setup.client()->StartPointerWatcher(true /* want_moves */);
+  uint32_t pointer_watcher_id2 = setup.GetPointerWatcherId();
 
-  // Simulate the server sending an observed event that matched the old observer
+  // Simulate the server sending an observed event that matched the old watcher
   // (e.g. that was in-flight when the observer was replaced).
   std::unique_ptr<ui::Event> pressed_event(
       new ui::MouseEvent(ui::ET_MOUSE_PRESSED, gfx::Point(), gfx::Point(),
                          ui::EventTimeForNow(), ui::EF_NONE, 0));
   setup.window_tree_client()->OnEventObserved(std::move(pressed_event),
-                                              event_observer_id1);
+                                              pointer_watcher_id1);
 
-  // The event was not sensed, because it does not match the current observer.
+  // The event was not sensed, because it does not match the current watcher.
   EXPECT_FALSE(setup.window_tree_delegate()->last_event_observed());
 
-  // Simulate another event that matches the new observer.
-  std::unique_ptr<ui::Event> released_event(
-      new ui::MouseEvent(ui::ET_MOUSE_RELEASED, gfx::Point(), gfx::Point(),
+  // Simulate another event that matches the new watcher.
+  std::unique_ptr<ui::Event> moved_event(
+      new ui::MouseEvent(ui::ET_MOUSE_MOVED, gfx::Point(), gfx::Point(),
                          ui::EventTimeForNow(), ui::EF_CONTROL_DOWN, 0));
-  setup.window_tree_client()->OnEventObserved(std::move(released_event),
-                                              event_observer_id2);
+  setup.window_tree_client()->OnEventObserved(std::move(moved_event),
+                                              pointer_watcher_id2);
 
   // The delegate sensed the event.
   ui::Event* last_event = setup.window_tree_delegate()->last_event_observed();
-  EXPECT_EQ(ui::ET_MOUSE_RELEASED, last_event->type());
+  EXPECT_EQ(ui::ET_MOUSE_MOVED, last_event->type());
   EXPECT_EQ(ui::EF_CONTROL_DOWN, last_event->flags());
 }
 
 // Verifies focus is reverted if the server replied that the change failed.
 TEST_F(WindowTreeClientTest, SetFocusFailed) {
   WindowTreeSetup setup;
   Window* root = setup.GetFirstRoot();
   ASSERT_TRUE(root);
   root->SetVisible(true);
   Window* child = setup.client()->NewWindow();
@@ skipping 457 matching lines @@
 
   // Create a new Window, and attempt to place capture on that.
   Window* child = setup.client()->NewWindow();
   child->SetVisible(true);
   root->AddChild(child);
   child->SetCapture();
   EXPECT_TRUE(child->HasCapture());
 }
 
 }  // namespace ui