chrome/browser/net/nqe/ui_network_quality_estimator_service_browsertest.cc - Issue 2183153002: NQE: Move ECT to net:: namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/nqe/ui_network_quality_estimator_service_browsertest.cc

Issue 2183153002: NQE: Move ECT to net:: namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased, also fixed comnpilation error Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/net/nqe/ui_network_quality_estimator_service.cc ('k') | chrome/browser/net/nqe/ui_network_quality_estimator_service_test_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/net/nqe/ui_network_quality_estimator_service_browsertest.cc

diff --git a/chrome/browser/net/nqe/ui_network_quality_estimator_service_browsertest.cc b/chrome/browser/net/nqe/ui_network_quality_estimator_service_browsertest.cc

index cc142f9d1c876ee68584de3fc76dd6941797fd88..d3ad81a5f7afe5e7d884e32ba8cbf43bc0a2ad28 100644

--- a/chrome/browser/net/nqe/ui_network_quality_estimator_service_browsertest.cc

+++ b/chrome/browser/net/nqe/ui_network_quality_estimator_service_browsertest.cc

@@ -8,7 +8,7 @@

#include "chrome/browser/profiles/profile_manager.h"

#include "chrome/test/base/in_process_browser_test.h"

#include "content/public/test/browser_test.h"

-#include "net/nqe/network_quality_estimator.h"

+#include "net/nqe/effective_connection_type.h"

#include "testing/gtest/include/gtest/gtest.h"

class Profile;

@@ -29,12 +29,12 @@ IN_PROC_BROWSER_TEST_F(UINetworkQualityEstimatorServiceBrowserTest,

UINetworkQualityEstimatorServiceFactory::GetForProfile(profile);

nqe_test_util::OverrideEffectiveConnectionTypeAndWait(

- net::NetworkQualityEstimator::EFFECTIVE_CONNECTION_TYPE_OFFLINE);

- EXPECT_EQ(net::NetworkQualityEstimator::EFFECTIVE_CONNECTION_TYPE_OFFLINE,

+ net::EFFECTIVE_CONNECTION_TYPE_OFFLINE);

+ EXPECT_EQ(net::EFFECTIVE_CONNECTION_TYPE_OFFLINE,

nqe_service->GetEffectiveConnectionType());

nqe_test_util::OverrideEffectiveConnectionTypeAndWait(

- net::NetworkQualityEstimator::EFFECTIVE_CONNECTION_TYPE_SLOW_2G);

- EXPECT_EQ(net::NetworkQualityEstimator::EFFECTIVE_CONNECTION_TYPE_SLOW_2G,

+ net::EFFECTIVE_CONNECTION_TYPE_SLOW_2G);

+ EXPECT_EQ(net::EFFECTIVE_CONNECTION_TYPE_SLOW_2G,

nqe_service->GetEffectiveConnectionType());

}