Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2183133002: Fix alignment problems in NEON Sk4b. (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
msarett
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix alignment problems in NEON Sk4b. As written at head, the compiler can assume these loads and stores are 4 byte aligned [1]. We want Sk4b to load from any 1-byte aligned address, to prevent crashes like [2]. [1] https://llvm.org/bugs/show_bug.cgi?id=24421 [2] https://luci-milo.appspot.com/swarming/task/304079e125b1b910/steps/nanobench/0/stdout BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2183133002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Committed: https://skia.googlesource.com/skia/+/a5e1e33d3916cf766f876d3def88afb373440a04

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/opts/SkNx_neon.h View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
mtklein_C
This has been waiting to strike for months.
4 years, 4 months ago (2016-07-26 16:36:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2183133002/1
4 years, 4 months ago (2016-07-26 16:36:21 UTC) #8
msarett
lgtm
4 years, 4 months ago (2016-07-26 17:06:29 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 17:07:38 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a5e1e33d3916cf766f876d3def88afb373440a04

Powered by Google App Engine
This is Rietveld 408576698