infra/mb/mb_config.pyl - Issue 2183063002: [build] Conditionally print to stdout on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: infra/mb/mb_config.pyl

Issue 2183063002: [build] Conditionally print to stdout on Android (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Define behind variable Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: infra/mb/mb_config.pyl

diff --git a/infra/mb/mb_config.pyl b/infra/mb/mb_config.pyl

index e4b751b9e097da84a376b2f509651571f76faecb..06a84962d5b0f700c9886f4e395e5e1f2bd7d36f 100644

--- a/infra/mb/mb_config.pyl

+++ b/infra/mb/mb_config.pyl

@@ -389,8 +389,8 @@

'mixins': {

'android': {

- 'gn_args': 'target_os="android"',

- 'gyp_defines': 'OS=android',

+ 'gn_args': 'target_os="android" v8_android_log_stdout=true',

+ 'gyp_defines': 'OS=android v8_android_log_stdout=1',

'arm': {

« no previous file with comments | « gypfiles/toolchain.gypi ('k') | no next file » | no next file with comments »