Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: BUILD.gn

Issue 2183063002: [build] Conditionally print to stdout on Android (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Define behind variable Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gypfiles/standalone.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 2972224d8e8b4bed1e6bea543fb4b8fff2de456e..9dad9cd2a0354a92b95a32fe6bafaef0957b0ea0 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -19,6 +19,9 @@ import("//build_overrides/v8.gni")
import("snapshot_toolchain.gni")
declare_args() {
+ # Print to stdout on Android.
+ v8_android_log_stdout = false
+
# Sets -DVERIFY_HEAP.
v8_enable_verify_heap = false
@@ -313,6 +316,9 @@ config("toolchain") {
ldflags += [ "/STACK:2097152" ]
}
}
+ if (is_android && v8_android_log_stdout) {
+ defines += [ "V8_ANDROID_LOG_STDOUT" ]
+ }
# TODO(jochen): Support v8_enable_prof on Windows.
# TODO(jochen): Add support for compiling with simulators.
« no previous file with comments | « no previous file | gypfiles/standalone.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698