Add mac hermetic support to build/config/mac/sdk_info.py.

build/toolchain/mac/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # TODO(brettw) Use "gcc_toolchain.gni" like the Linux toolchains. This requires
 # some enhancements since the commands on Mac are slightly different than on
 # Linux.
 
 import("../goma.gni")
 import("//build/config/clang/clang.gni")
-import("//build/config/ios/ios_sdk.gni")
+if (is_ios) {
+  import("//build/config/ios/ios_sdk.gni")
+}
 import("//build/config/mac/mac_sdk.gni")
 import("//build/config/mac/symbols.gni")
 
 assert(host_os == "mac")
 
 import("//build/toolchain/cc_wrapper.gni")
 import("//build/toolchain/goma.gni")
 import("//build/toolchain/toolchain.gni")
 import("//build/toolchain/concurrent_links.gni")
 
@@ skipping 371 matching lines @@
 mac_toolchain("clang_arm") {
   toolchain_cpu = "arm"
   toolchain_os = "mac"
 }
 
 mac_toolchain("clang_x64") {
   toolchain_cpu = "x64"
   toolchain_os = "mac"
 }
 
-mac_toolchain("ios_clang_arm") {
-  toolchain_cpu = "arm"
-  toolchain_os = "ios"
+if (is_ios) {

[sdefresne, 2016/07/28 17:36:31]

I don't think this is necessary, instead you could do the following at the top
of the file which should work:

if (is_ios) {
  import("//build/config/ios/ios_sdk.gni")
} else {
  additional_toolchains = []
}

[justincohen, 2016/07/28 17:59:40]

Generating files...
ERROR at //build/toolchain/mac/BUILD.gn:14:27: Assignment had no effect.
  additional_toolchains = []
                          ^
You set the variable "additional_toolchains" here and it was unused before it
went
out of scope.
See //BUILD.gn:65:1: which caused the file to be included.
group("gn_all") {
^----------------

[Dirk Pranke, 2016/07/28 19:07:20]

That, plus it's probably better hygiene to not declare these targets on non-ios
builds.

+  mac_toolchain("ios_clang_arm") {
+    toolchain_cpu = "arm"
+    toolchain_os = "ios"
+  }
+
+  mac_toolchain("ios_clang_arm64") {
+    toolchain_cpu = "arm64"
+    toolchain_os = "ios"
+  }
+
+  mac_toolchain("ios_clang_x86") {
+    toolchain_cpu = "x86"
+    toolchain_os = "ios"
+  }
+
+  mac_toolchain("ios_clang_x64") {
+    toolchain_cpu = "x64"
+    toolchain_os = "ios"
+  }
 }
-
-mac_toolchain("ios_clang_arm64") {
-  toolchain_cpu = "arm64"
-  toolchain_os = "ios"
-}
-
-mac_toolchain("ios_clang_x86") {
-  toolchain_cpu = "x86"
-  toolchain_os = "ios"
-}
-
-mac_toolchain("ios_clang_x64") {
-  toolchain_cpu = "x64"
-  toolchain_os = "ios"
-}