Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2183043002: [turbofan] Perform element index computation in word64 on 64-bit platforms. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Perform element index computation in word64 on 64-bit platforms. This allows us to fuse the address computation with the actual memory access operation on x64, which reduces the register pressure and the number of instructions. There's probably some follow up cleanup that has to happen to make sure the machine operator optimizations that are relevant to word64 computations are also available (similar to what is already available for word32). R=epertoso@chromium.org Committed: https://crrev.com/5d2d46e3880063269e84234d9e10fff7ab8f3997 Cr-Commit-Position: refs/heads/master@{#38051}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -28 lines) Patch
M src/compiler/memory-optimizer.cc View 1 chunk +18 lines, -13 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 chunk +30 lines, -15 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Benedikt Meurer
4 years, 4 months ago (2016-07-26 12:53:42 UTC) #1
Benedikt Meurer
Hey Enrico, Here's a simple change to make the pesky leal's go away on x64. ...
4 years, 4 months ago (2016-07-26 12:55:02 UTC) #4
epertoso
lgtm
4 years, 4 months ago (2016-07-26 12:57:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2183043002/1
4 years, 4 months ago (2016-07-26 12:57:40 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 13:13:48 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 13:14:12 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d2d46e3880063269e84234d9e10fff7ab8f3997
Cr-Commit-Position: refs/heads/master@{#38051}

Powered by Google App Engine
This is Rietveld 408576698